Fix null errors on live reads and stop leaked API test deployments - #9839
Merged
Merged
Conversation
…the live api test fails The live results converter set Errors to null whenever the response carried no errors array, which is every successful read, so callers joining the errors threw. The CreatesLiveAlgorithm api test hit exactly that, and its cleanup deleted the project without stopping the deployment, leaving live nodes busy for later runs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LiveAlgorithmResultsJsonConvertersetErrorsto null when the response had noerrorsarray (every successful read), sostring.Joinon it threw. It now keeps an empty list like every other response.CreatesLiveAlgorithmfailed on exactly that, and its catch deleted the project without stopping the deployment, leaving live nodes busy. The catch now liquidates first and rethrows with the original stack.Verified locally: converter unit tests plus
CreatesLiveAlgorithmandReadLiveInsightsWorksAsExpectedpass against the API.🤖 Generated with Claude Code