Skip to content

Use uv lock file when installing dependencies in noxfile - #6561

Open
bschoenmaeckers wants to merge 4 commits into
PyO3:mainfrom
bschoenmaeckers:nox-uv
Open

bschoenmaeckers wants to merge 4 commits into
PyO3:mainfrom
bschoenmaeckers:nox-uv

Conversation

@bschoenmaeckers

Copy link
Copy Markdown
Member

Alternative to #6560 to unblock CI

@bschoenmaeckers bschoenmaeckers added the CI-skip-changelog Skip checking changelog entry label Oct 29, 2026
@bschoenmaeckers
bschoenmaeckers force-pushed the nox-uv branch 6 times, most recently from c764b99 to ed920a1 Compare October 29, 2026 14:57
@Tpt

Tpt commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

nox-uv seems to be a small project (single author, last commit 5 months ago). Do we want to depend on it?

@bschoenmaeckers

Copy link
Copy Markdown
Member Author

nox-uv seems to be a small project (single author, last commit 5 months ago). Do we want to depend on it?

It's in the nox docs so maybe its fine. We can also implement this behaviour ourselves (once I get the CI green).

@bschoenmaeckers
bschoenmaeckers force-pushed the nox-uv branch 2 times, most recently from 4718c78 to caf64a2 Compare October 29, 2026 15:52
@bschoenmaeckers

Copy link
Copy Markdown
Member Author

@Tpt I've removed nox-uv

@codspeed

codspeed Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

1 warning

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 141 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ into_bigint_big_positive 4.2 µs 4.7 µs -10.57%
⚡ call_method_0 1.8 ms 1.6 ms +14.21%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing bschoenmaeckers:nox-uv (72717fe) with main (26f9ec8)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Comment thread noxfile.py Outdated
Comment thread noxfile.py Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants