Skip to content

Fix the issue where pytest-benchmark temporarily doesn't support pytest version 9.2.0 - #6560

Open
wenming21 wants to merge 3 commits into
PyO3:mainfrom
wenming21:main
Open

wenming21 wants to merge 3 commits into
PyO3:mainfrom
wenming21:main

Conversation

@wenming21

Copy link
Copy Markdown

An error occurred when running CI: the latest version of pytest is not compatible with the latest version of pytest-benchmark.

@wenming21

This comment was marked as low quality.

@codspeed

codspeed Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

1 warning

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 141 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ into_bigint_big_positive 4.2 µs 4.7 µs -10.57%
⚡ call_method_0 1.8 ms 1.6 ms +14.21%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing wenming21:main (cd1506e) with main (26f9ec8)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Fix incompatibility between the latest version of pytest and the latest version of pytest-benchmark, pytest-benchmark doesn't currently support pytest version 9.2.0
@wenming21

Copy link
Copy Markdown
Author

Merging this PR will degrade performance by 10.56%

1 warning

⚠️ Base and head ran on different runner types
Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.
Learn more about Macro Runners
Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks ✅ 141 untouched benchmarks ⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ into_biguint_big 4.2 µs 4.7 µs -10.57%
❌ into_bigint_big_negative 4.2 µs 4.7 µs -10.55%
Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing wenming21:main (45d0220) with main (26f9ec8)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codspeedbot This should be machine fluctuation, not an actual decline in performance.

@bschoenmaeckers

Copy link
Copy Markdown
Member

For reference, this issue is tracked in ionelmc/pytest-benchmark#321

Comment thread newsfragments/6560.fixed.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not require a changelog

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has been deleted

Comment thread pytests/pyproject.toml Outdated
"pytest-asyncio>=0.21,<2",
"pytest-benchmark>=3.4",
"pytest>=7",
"pytest>=7,<9.2",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of limiting the version here, I think we should track this in the root uv.lock file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The restriction for pytest<9.2.0 has been moved to the uv.lock in the root directory.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I went ahead and filed #6561. This locked pytest to a working version without version constraints.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants