Repository navigation
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
Merging this PR will regress 1 benchmark1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
Fix incompatibility between the latest version of pytest and the latest version of pytest-benchmark, pytest-benchmark doesn't currently support pytest version 9.2.0
@codspeedbot This should be machine fluctuation, not an actual decline in performance. |
|
For reference, this issue is tracked in ionelmc/pytest-benchmark#321 |
There was a problem hiding this comment.
This change does not require a changelog
| "pytest-asyncio>=0.21,<2", | ||
| "pytest-benchmark>=3.4", | ||
| "pytest>=7", | ||
| "pytest>=7,<9.2", |
There was a problem hiding this comment.
Instead of limiting the version here, I think we should track this in the root uv.lock file.
There was a problem hiding this comment.
There was a problem hiding this comment.
And to wire this to nox see: https://nox.thea.codes/en/stable/cookbook.html#using-a-lockfile
There was a problem hiding this comment.
The restriction for pytest<9.2.0 has been moved to the uv.lock in the root directory.
There was a problem hiding this comment.
Sorry I went ahead and filed #6561. This locked pytest to a working version without version constraints.
An error occurred when running CI: the latest version of pytest is not compatible with the latest version of pytest-benchmark.