Route OT-2 fixed-trash disposal by API version - #1241
Merged
rickwierenga merged 1 commit intoSep 3, 2026
Conversation
Text comparison treats API 26.6.0 as older than 7.1.0. Fixed-trash disposal then enters the tip-rack path and fails before sending the required commands. Parse the numeric release components and select the addressable-area commands only for fixed-trash disposal. Accept release suffixes, reject versions without a numeric release prefix, and keep ordinary tip returns independent of version parsing.
rickwierenga
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OT-2 backend selected its fixed-trash command route by comparing server versions as text. A multi-digit version such as
26.6.0was therefore treated as older than7.1.0and entered the tip-rack path.Verification
python -m pytest pylabrobot/legacy/liquid_handling/backends/opentrons_backend_tests.py pylabrobot/legacy/liquid_handling/backends/opentrons_chatterbox_tests.py -q— 32 passed.26.6.0: fixed-trash disposal completed with the P20 and P300 pipettes using the numeric route-selection implementation.Repository-wide
make lintandmake format-checkstill report existing failures outside this change.