Skip to content

Preserve the selection stack for out-of-range Eq calls #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mna merged 1 commit into from
Oct 21, 2026
+12 −1
Merged

Preserve the selection stack for out-of-range Eq calls #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion array.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func (s *Selection) Eq(index int) *Selection {
}

if index >= len(s.Nodes) || index < 0 {
return newEmptySelection(s.document)
return pushStack(s, nil)
}

return s.Slice(index, index+1)
Expand Down
11 changes: 11 additions & 0 deletions array_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,17 @@ func TestEqRollback(t *testing.T) {
assertEqual(t, sel, sel2)
}

func TestEqOutOfRangeRollback(t *testing.T) {
for _, sel := range []*Selection{Doc().Find(".pvk-content"), Doc().Find("missing")} {
for _, index := range []int{sel.Length(), -sel.Length() - 1} {
empty := sel.Eq(index)
assertLength(t, empty.Nodes, 0)
assertEqual(t, sel, empty.End())
assertLength(t, empty.AddBack().Nodes, sel.Length())
}
}
}

func TestSlice(t *testing.T) {
sel := Doc().Find(".pvk-content").Slice(0, 2)

Expand Down
Loading