Repository navigation
Preserve the selection stack for out-of-range Eq calls - #621
Merged
Merged
Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
Member
|
Thanks, LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sel.Eq(999).End()loses the original selection because the out-of-range branch creates an empty selection without a previous-selection link.AddBack()also returns nothing, even whenselcontains nodes.Use
pushStack(s, nil)for that branch, matching other filtering methods. Tests cover positive and negative out-of-range indices on both populated and empty selections. They fail before the fix and check thatEqstays empty whileEndandAddBackrestore the previous selection.go test ./... -count=1,go vet ./...and gofmt pass.