Repository navigation
refactor(reqif): move ReqIF adapter into ufo_types::reqif - #43
Merged
Merged
Conversation
reqif_adapter.rs (ReqIfBundle -> RequirementGraph mapping) and the reqrs parse call move into ufo-types' new `reqif` feature module (sibling commit a1f6a89, PromptExecution/ufo-types), per docs/DESIGN-NOTE-versioned-dialects-and-b00t-loader.md §3: the orphan rule means kr0ki-core can't impl a foreign trait (Upgrade) on a foreign type (RequirementGraph), so the bridge lives where the type does. reqif_import.rs now calls ufo_types::reqif::parse_and_lower instead of reqrs directly; its own ReqIfImportError::Parse and ::Adapter variants collapse into one (ufo_types::reqif's own ReqIfAdapterError already covers both). No change to the shipped HTTP/MCP contract shape (POST /requirements/import, import_reqif tool) -- verified by the existing kr0ki-server requirements_import_* tests, unmodified and passing. Depends on the sibling ufo-types commit above landing (tag bump) -- not independently buildable without it. Cargo.lock and the root Cargo.toml's dev-only ufo-types path [patch] are intentionally left uncommitted; the patch is local-only wiring to build against that commit before it's tagged, not a real dependency change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Drops the local-path [patch] used while a1f6a89 was uncommitted/ unpushed -- ufo-types@a1f6a89 is now pushed, so kr0ki-core pins it by rev directly (no tag exists past v0.15.0 yet covering this commit). Verified: cargo build -p kr0ki-core and cargo test -p kr0ki-core --lib (156/156) both pass against the real git dependency, no local override.
2 tasks done
elasticdotventures
added a commit
that referenced
this pull request
Sep 20, 2026
…anch (#45) PR #43's rev pin (a1f6a89) pointed at feat/mbse-requirements, whose tip no longer exists as a reachable ref after ufo-types#29 squash- merged it into main and the branch was deleted. Re-pinned to the resulting merge commit on main (ee873488). Verified: cargo build -p kr0ki-core and cargo test -p kr0ki-core --lib (156/156) both pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/kr0ki-core/src/reqif_adapter.rsand thereqrsparse call move intoufo_types::reqif(sibling PR: feat: versioned dialect contracts + ReqIF adapter migration ufo-types#29), perdocs/DESIGN-NOTE-versioned-dialects-and-b00t-loader.md§3 — the Rust orphan rule means kr0ki-core can'timpla foreign trait (Upgrade) on a foreign type (RequirementGraph), so the bridge has to live where the type does.reqif_import.rsnow callsufo_types::reqif::parse_and_lowerinstead ofreqrsdirectly;ReqIfImportError::Parseand::Adaptercollapse into one variant (ufo_types::reqif's ownReqIfAdapterErroralready covers both).ufo-typesdependency pinned byrevto the pushedfeat/mbse-requirementscommit (no tag exists past v0.15.0 covering it yet) — bump to atag =pin once that lands and a release is cut.No change to the shipped HTTP/MCP contract shape (
POST /requirements/import,import_reqiftool).Test plan
cargo build -p kr0ki-coreagainst the real (pushed) ufo-types git dependency, no local overridecargo test -p kr0ki-core --lib— 156/156 passcargo test -p kr0ki-server— 47/47 pass, includingrequirements_import_*andmcp_tools_lists_all_thirteen_tools_with_bindings