Skip to content

fix(database): restrict workspace service RPCs #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Programcode merged 1 commit into from
Sep 22, 2026
Merged

fix(database): restrict workspace service RPCs #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions supabase/migrations/20260922233256_harden_workspace_function_acl.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
REVOKE ALL ON FUNCTION public.start_workspace_thread_generation(uuid, uuid, uuid, uuid, uuid, uuid, text),
public.complete_workspace_thread_generation(uuid, uuid, uuid, uuid, text, text)
FROM PUBLIC, anon, authenticated;

GRANT EXECUTE ON FUNCTION public.start_workspace_thread_generation(uuid, uuid, uuid, uuid, uuid, uuid, text),
public.complete_workspace_thread_generation(uuid, uuid, uuid, uuid, text, text)
TO service_role;

REVOKE ALL ON FUNCTION private.capture_workspace_version_text(),
private.restore_workspace_state_text()
FROM PUBLIC, anon, authenticated, service_role;
20 changes: 19 additions & 1 deletion supabase/tests/workspace_practice_test.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
BEGIN;
SELECT plan(30);
SELECT plan(32);

SELECT has_table('public', 'workspace_sources', 'shared sources exist');
SELECT has_table('public', 'workspace_threads', 'shared threads exist');
Expand All @@ -11,6 +11,24 @@ SELECT has_function('public', 'save_workspace_thread_message', ARRAY['uuid','uui
SELECT has_function('public', 'start_workspace_thread_generation', ARRAY['uuid','uuid','uuid','uuid','uuid','uuid','text'], 'thread generation starts atomically');
SELECT has_function('public', 'complete_workspace_thread_generation', ARRAY['uuid','uuid','uuid','uuid','text','text'], 'assistant completion stays server-owned');
SELECT has_function('public', 'save_workspace_artifact', ARRAY['uuid','uuid','uuid','uuid','bigint','text','text','jsonb','jsonb','jsonb'], 'artifacts use an authorized RPC');
SELECT ok(
NOT has_function_privilege('anon', 'public.start_workspace_thread_generation(uuid,uuid,uuid,uuid,uuid,uuid,text)', 'EXECUTE')
AND NOT has_function_privilege('anon', 'public.complete_workspace_thread_generation(uuid,uuid,uuid,uuid,text,text)', 'EXECUTE')
AND NOT has_function_privilege('authenticated', 'public.start_workspace_thread_generation(uuid,uuid,uuid,uuid,uuid,uuid,text)', 'EXECUTE')
AND NOT has_function_privilege('authenticated', 'public.complete_workspace_thread_generation(uuid,uuid,uuid,uuid,text,text)', 'EXECUTE')
AND has_function_privilege('service_role', 'public.start_workspace_thread_generation(uuid,uuid,uuid,uuid,uuid,uuid,text)', 'EXECUTE')
AND has_function_privilege('service_role', 'public.complete_workspace_thread_generation(uuid,uuid,uuid,uuid,text,text)', 'EXECUTE'),
'thread generation RPCs are service-role only'
);
SELECT ok(
NOT has_function_privilege('anon', 'private.capture_workspace_version_text()', 'EXECUTE')
AND NOT has_function_privilege('authenticated', 'private.capture_workspace_version_text()', 'EXECUTE')
AND NOT has_function_privilege('service_role', 'private.capture_workspace_version_text()', 'EXECUTE')
AND NOT has_function_privilege('anon', 'private.restore_workspace_state_text()', 'EXECUTE')
AND NOT has_function_privilege('authenticated', 'private.restore_workspace_state_text()', 'EXECUTE')
AND NOT has_function_privilege('service_role', 'private.restore_workspace_state_text()', 'EXECUTE'),
'workspace text projection triggers are not directly executable'
);

INSERT INTO auth.users (id) VALUES
('91111111-1111-4111-8111-111111111111'),
Expand Down
Loading