Repository navigation
Restore Browser nightly coverage after UI and API changes - #279
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex review round 1 completed with no findings at head Quality run 41044138632 passed lint, typecheck/build, unit tests, Edge Function tests, and browser smoke on this exact head. Local evidence is 96/96 cases in the seven named specs, 20/20 consecutive onboarding runs with one worker and no retries, and all ten Copilot returned a quota-only notice and is not counted as a substantive review. No open review findings remain. Adam explicitly authorized full send through merge; the local verification, current-head CI, and substantive Codex review gates are met. The post-merge Browser nightly run will be recorded in a follow-up. |
|
Post-merge verification is complete at
The post-merge nightly dispatch was already complete when the resumed session checked it, so no duplicate workflow run was started. Browser verification on the VPS used a temporary isolated network namespace to avoid unrelated Docker bridge/veth churn; assertions and app configuration were unchanged. |
The Browser nightly failures on
maincame from tests that still assumed the UI, loading behavior, and usage API from before the October changes. This updates seven browser specs to exercise the current behavior. No application code, workflow, dependencies, Supabase stack, or verification tooling changes.Each reported failure was checked against source and the failing browser output:
bannerlandmark; page-level headers are valid and must remain.ai_usage_todayRPC instead of the retiredai_requestsquery, retaining the exact one-read assertion across sibling routes. Return PostgREST's 406 for an empty required single-row read so settings hydration does not treat an invalid array response as an account and issue an unrelated billing read.2dc73ff3. Replace the obsolete 100ms post-navigation absence check with a controlled-clock check that the tour stays closed on the protected tool past its deadline, then opens at the visible Home target. No timeout increases or retries added.Baseline at
151842f3: 14 deterministic failures reproduced locally in the reported cases; onboarding and Flowchart passed that baseline, consistent with timing-sensitive failures in Actions.Local browser runs encountered Chromium
ERR_NETWORK_CHANGEDon localhost source-module fetches while other work changed Docker bridge/veth interfaces on the shared VPS. A read-onlyip monitor linkcaptured 54 lines of interface events in 40 seconds. Verification uses a temporary process network namespace, with the repository commands running as the workspace owner on Node 22, to keep those host interface changes out of Chromium. No host networking, application code, or other agents' containers were changed. The namespace has loopback and an isolated dummy interface so online-reload behavior is still exercised. A focused check of onboarding, chunk recovery, and subscription caching passed all six desktop/mobile cases there with retries disabled.At head
fc391496e096f68ada3a208aad167e7bc9748643, the complete seven named specs passed on desktop Chromium and mobile Chromium: 96 passed, with zero retries, in 6.1 minutes. Command run inside the isolated network namespace:The onboarding test then passed 20 consecutive runs, ten on desktop and ten on mobile, with one worker and zero retries, at the same head:
npm run verifypassed all ten steps at the same head in 147.7 seconds, started in a nonblocking background session. This includes docs, jargon, lint, typecheck, unit tests, collaboration, build, browser smoke, service-worker offline, and 505 Edge Function tests. No local Supabase stack was started, and the full local browser suite has not been run.These are credential-free client checks with stub sessions and responses; they do not prove authenticated backend, staging, production, or live AI behavior. Desktop and mobile screenshots show the Hungarian not-found heading and language control exercised by the corrected spec.
Adam explicitly requested full send through merge. This PR will merge after final local verify, current-head Quality CI, and a clean substantive Codex review, with at most three review rounds. After merging, Browser nightly will be dispatched once on
mainand its result recorded here.