Repository navigation
Check every recipe screenshot for overflow and broken images - #281
Merged
Merged
Conversation
Agents kept screenshots as evidence without opening them; in October one shipped a broken LaunchIgniter badge in its own screenshot. Each evidence.shot() now soft-asserts that the page is no wider than the screen and that every visible image loaded, so the recipe reports every bad screen instead of relying on someone to look. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The not-found page now shows "404" as an eyebrow and the translated message as its h1, so the recipe failed looking for a "404" heading. #279 fixed the same assertion in e2e/localization.spec.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Review round 1 (Claude, bb3408b; Codex is at its usage cap): nothing blocking.
CI is green and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents keep verify-debatelab screenshots as evidence without opening them. In October one shipped a broken LaunchIgniter badge in its own screenshot, and a coordinator caught it later. Every
evidence.shot()now also checks the page it just captured:The checks are soft assertions, so one recipe reports every bad screen. The recipe fixtures already checked overflow, but only at the end of a test; now each screenshot is checked when it's taken. SKILL.md documents the check and says to keep opening screenshots, because it can't see clipped text, overlaps or wrong colours.
Running every recipe also turned up a stale assertion on main.
loc-switcherlooked for a "404" h1, but the not-found page now shows the translated message as its h1 and "404" as an eyebrow. #279 fixed the same assertion ine2e/localization.spec.ts.Verification
npm run verifypassed at this head (10 steps, 126 s).lib-edit-while-switching(anot.toBeCheckedrace), which passed in the previous mobile run on the same code; it isn't overflow or images.This changes test tooling only, so it's low-risk under AGENTS.md.
🤖 Generated with Claude Code