Repository navigation
Apply DB-05 duplicate-index drop and promo_redeem_failures primary key as migrations - #218
Conversation
…y as migrations Adam approved these on 23 Oct 2026. Both move from supabase/proposed/ to supabase/migrations/ under new timestamps so main and the hosted projects stay in sync. DB-04 (staging_auto_admin) was run by hand on staging as its header requires and is removed from proposed/. DB-03 stays proposed.
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 30 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
|
Verified on the VPS at d734938: npm run verify exit 0 (docs, lint incl. squawk, typecheck, 586 unit, 30 collab, 457 edge, build + check-site 48, test:sw, 47 e2e smoke) and .superset/db-gate.sh --db-only exit 0 (pgTAP 28 files / 516 tests, database scripts; stack stopped). GitHub Actions jobs fail at start (2-3s), as on #209. |
Adam approved on 23 Oct 2026 (09:18 CEST): run the safe cleanup scripts from
supabase/proposed/.20261023073000_drop_duplicate_indexes.sql(DB-05): drops 6 indexes that duplicate another index. Each drop is guarded, so it runs only if the kept twin exists, is valid and identical. Moved unchanged fromsupabase/proposed/20261023060200_*; only the header changed.20261023073100_promo_redeem_failures_primary_key.sql: adds an identityidprimary key toprivate.promo_redeem_failures.redeem_promo_code_atomicinserts onlyuser_id, so it needs no change. Moved fromsupabase/proposed/20261023060300_*.supabase/proposed/20261023060100_drop_staging_auto_admin.sql(DB-04) is removed. Its header forbids adding it to migrations, so it was run by hand on staging (23 Oct ~09:30 CEST, in a transaction; the definition is backed up off-repo). Production never had the function.proposed/. It was dry-run on staging only (rolled back).No functions or app code changed. After merge, the staging timer applies the two migrations; production gets
supabase db pushonce staging checks out.