Merge origin/main (#218) into fix/t6-usage-pricing

Author: Programcode

…0261023060200_drop_duplicate_indexes.sql …0261023073000_drop_duplicate_indexes.sqlsupabase/proposed/20261023060200_drop_duplicate_indexes.sql renamed to supabase/migrations/20261023073000_drop_duplicate_indexes.sql supabase/proposed/20261023060200_drop_duplicate_indexes.sql renamed to supabase/migrations/20261023073000_drop_duplicate_indexes.sql

@@ -1,5 +1,5 @@
--- DB-05 (proposed, destructive): drop indexes that duplicate another index
--- on the same table and column.
+-- DB-05: drop indexes that duplicate another index on the same table and
+-- column. Approved by Adam 23 Oct 2026; moved from supabase/proposed/.
 --
 --   subscriptions      idx_subscriptions_stripe_customer duplicates
 --                      idx_subscriptions_stripe_customer_id (both plain

…00_promo_redeem_failures_primary_key.sql …00_promo_redeem_failures_primary_key.sqlsupabase/proposed/20261023060300_promo_redeem_failures_primary_key.sql renamed to supabase/migrations/20261023073100_promo_redeem_failures_primary_key.sql supabase/proposed/20261023060300_promo_redeem_failures_primary_key.sql renamed to supabase/migrations/20261023073100_promo_redeem_failures_primary_key.sql

@@ -1,4 +1,5 @@
--- DB-05 (proposed): give private.promo_redeem_failures a primary key.
+-- DB-05: give private.promo_redeem_failures a primary key (approved by Adam
+-- 23 Oct 2026; moved from supabase/proposed/).
 --
 -- It is the one table without a primary key. Its natural columns
 -- (user_id, failed_at) can repeat when two failures share a timestamp, so a
@@ -10,5 +11,7 @@
 -- IF NOT EXISTS skips the whole statement, primary key included; check with
 -- `\d private.promo_redeem_failures` first.
 
-ALTER TABLE private.promo_redeem_failures
-  ADD COLUMN IF NOT EXISTS id bigint GENERATED ALWAYS AS IDENTITY PRIMARY KEY;
+-- The rewrite and lock are accepted: the table holds a handful of rows
+-- (1 on production on 23 Oct 2026) and only promo redemption writes to it.
+-- squawk-ignore adding-field-with-default,adding-serial-primary-key-field
+ALTER TABLE private.promo_redeem_failures ADD COLUMN IF NOT EXISTS id bigint GENERATED ALWAYS AS IDENTITY PRIMARY KEY;

…/20261023060000_drop_legacy_policies.sql …/20261023080000_drop_legacy_policies.sqlsupabase/proposed/20261023060000_drop_legacy_policies.sql renamed to supabase/migrations/20261023080000_drop_legacy_policies.sql supabase/proposed/20261023060000_drop_legacy_policies.sql renamed to supabase/migrations/20261023080000_drop_legacy_policies.sql

@@ -1,4 +1,7 @@
--- DB-03 (proposed, destructive): drop policies that no migration created.
+-- DB-03: drop policies that no migration created. Approved by Adam on
+-- 23 Oct 2026; moved from supabase/proposed/. It was run by hand on staging
+-- and production first, after shared links, role reads and usage counts were
+-- tested on staging, so on both hosted projects this finds nothing to drop.
 --
 -- The QA run on 22 Oct 2026 found policies on production that are not in
 -- staging or in supabase/migrations, including duplicate permissive ones on
@@ -24,7 +27,8 @@
 -- caller's own rows: without user_roles_select_own, signed-in users could no
 -- longer read their own role (SettingsPage and the curated_sources admin
 -- policies depend on it), and a drifted copy would keep the leak this fixes.
--- Do a dry run first (BEGIN; ...; ROLLBACK;).
+-- Running it again changes nothing: every drop is IF EXISTS and the kept
+-- policies are never dropped.
 
 DO $$
 DECLARE