Skip to content

Fix flaky SharedPage not-found title test #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Programcode merged 1 commit into from
Oct 23, 2026
Merged

Fix flaky SharedPage not-found title test #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/test/pages/SharedPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { render, screen } from '@testing-library/react';
import { render, screen, waitFor } from '@testing-library/react';
import { MemoryRouter, Route, Routes } from 'react-router-dom';
import { AuthContext, type AuthContextValue } from '@/lib/supabase/auth-context';
import SharedPage from '@/pages/SharedPage';
Expand Down Expand Up @@ -54,8 +54,11 @@ describe('a missing share link', () => {
expect(screen.queryByRole('heading', { name: 'Shared Content' })).not.toBeInTheDocument();
expect(screen.getByText('This shared content is no longer available')).toBeInTheDocument();
expect(screen.getByRole('link', { name: 'Back to home' })).toHaveAttribute('href', '/');
expect(document.title).toBe('Shared link not found · DebateLab');
expect(document.head.querySelector('meta[name="robots"]')?.getAttribute('content')).toBe('noindex, nofollow');
// The heading commits before the passive effect that sets the title and robots meta runs.
await waitFor(() => expect(document.title).toBe('Shared link not found · DebateLab'));
await waitFor(() =>
expect(document.head.querySelector('meta[name="robots"]')?.getAttribute('content')).toBe('noindex, nofollow'),
);
});

it('still shows a shared item that exists', async () => {
Expand Down
Loading