Repository navigation
Fix flaky SharedPage not-found title test - #205
Merged
Merged
Conversation
The not-found heading commits before the passive effect that sets document.title and the robots meta, so asserting right after findByRole failed about 1 run in 12-15. Wait for both. Test-only; the component is correct.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
Note 🎁 Summarized by CodeRabbit Free
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharedPage.test.tsx asserted document.title (and the robots meta) right after findByRole found the not-found heading. That heading commits before the passive effect that sets them runs, so the test failed intermittently (reproduced: 1 failure in 15 runs on main 4338727).
Change (test only): wait for the title and robots meta with waitFor. The component is correct: setting the title in an effect is the expected pattern.
Checks: the test file passed 20/20 runs in a row; lint, typecheck and unit tests (74 files) pass. Full verify skipped (test-only change; the shared stack lock was held by another job).