Skip to content

Fix Java 1.20.5 item durability data - #1288

Open
Pix3lPirat3 wants to merge 3 commits into
PrismarineJS:masterfrom
Pix3lPirat3:fix/java-1.20.5-item-durability
Open

Pix3lPirat3 wants to merge 3 commits into
PrismarineJS:masterfrom
Pix3lPirat3:fix/java-1.20.5-item-durability

Conversation

@Pix3lPirat3

@Pix3lPirat3 Pix3lPirat3 commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Use untouched generator output for the shared 1.20.5/1.20.6 item file.
Align enchantment categories and restore native repair ingredients alongside the existing durability corrections. Add regression checks for these fields.

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

The correction looks ready from this review of 1239444. The entire 1,330-item file matches the native 1.20.5 output downloaded from generator #82’s exact-head CI run 35411397047, including the category names and repair ingredients, not only durability. I verified both 1.20.5 and 1.20.6 select this file. All 1,864 semantic/schema tests passed locally; the suite command failed only its global 40-second timing guard under concurrent review load (68 seconds). I inspected generated CI output rather than rerunning Java generation locally.

Skills used: prismarine-protocol-data-review compared complete generated output and traced dataPaths consumers; prismarine-item-inventory-review checked durability, repair ingredients and enchantment-category consumers; prismarine-review separated data assertions from the local timing limitation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants