Skip to content

Fix generator startup and item data - #82

Open
Pix3lPirat3 wants to merge 1 commit into
PrismarineJS:mainfrom
Pix3lPirat3:fix/1.14-item-durability
Open

Pix3lPirat3 wants to merge 1 commit into
PrismarineJS:mainfrom
Pix3lPirat3:fix/1.14-item-durability

Conversation

@Pix3lPirat3

@Pix3lPirat3 Pix3lPirat3 commented Sep 11, 2026 •

Copy link
Copy Markdown

This patch tracks generator instantiation failures during startup and includes them in the overall failure count, preventing false success reports. It also corrects the 1.14 item maximum durability lookup to use the durability API and fixes a 1.7 variant-item bug by creating a fresh JSON object for each item variant.

Related PRs:

This patch tracks generator instantiation failures during startup and includes them in the overall failure count, preventing false success reports. It also corrects the 1.14 item maximum durability lookup to use the durability API and fixes a 1.7 variant-item bug by creating a fresh JSON object for each item variant.
@Pix3lPirat3
Pix3lPirat3 force-pushed the fix/1.14-item-durability branch from 64781b1 to be8baa1 Compare September 19, 2026 01:01

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

The three repairs look sound from this review of be8baa1. I compiled the actual DataGenerators/IDataGenerator classes with the declared Gson/ClassGraph dependencies and verified that a constructor failure makes runDataGenerators return false while another generator still writes its output. Exact-head CI artifacts also show correct 1.14 durability (for example diamond sword 1561) and distinct sequential variant IDs for all 15 variant-bearing 1.7 items. The native 1.20.5 items output matches companion data #1288 exactly. I used CI artifacts for native Minecraft output; I did not rerun the complete Gradle/server matrix locally.

Skills used: prismarine-protocol-data-review checked the live producer and exact-head generated outputs; prismarine-review verified failure propagation with the actual common implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants