Repository navigation
fix(desktop): keep task startup in loading state - #95870
Conversation
|
😎 Merged successfully - details. |
|
React Doctor found 2 issues in 2 files · 2 warnings. 2 warnings
Reviewed by React Doctor for commit |
🤖 CI report✅ Trunk lane — non-backend lane (
|
HostHog preview —
|
|
Reviews (1): Last reviewed commit: "Merge branch 'master' into posthog/optim..." | Re-trigger Greptile |
881e9f0 to
570529b
Compare
Show one optimistic loading state until the active run starts. Replace the loading state with a clear failure result when startup fails. Generated-By: PostHog Desktop Task-Id: 43a66a0d-939d-4204-ac8a-c6a5d8233eb5
Track startup by run and preserve first-prompt state across hydration. Clear loading only for matching prompt, failure, offline, or terminal transitions. Generated-By: PostHog Desktop Task-Id: 43a66a0d-939d-4204-ac8a-c6a5d8233eb5
Update the recovery test for run-bound startup markers. Generated-By: PostHog Desktop Task-Id: 43a66a0d-939d-4204-ac8a-c6a5d8233eb5
Keep the latest session summary component while removing obsolete startup imports. Generated-By: PostHog Desktop Task-Id: 43a66a0d-939d-4204-ac8a-c6a5d8233eb5
b752543 to
a6add0f
Compare
There was a problem hiding this comment.
Approved.
Contained UI/state-machine change to the desktop app's own task-status display (no auth, billing, migration, or CI surface), authored by a member of the owning team with extensive new/updated tests covering the added lifecycle edge cases, and no unresolved reviewer concerns.
- Author wrote 21% of the modified lines and has 53 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
- 27 of the 27 changed files are governed by
products/desktop/AGENT_APPROVALS.md.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 577L, 17F substantive, 942L/27F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (942L, 27F, single-area, fix) |
| stamphog 2.0.0b4 | .stamphog/policy.yml @ a6add0f · reviewed head a6add0f |
Problem
People see several infrastructure states while a task starts, which makes normal startup look stalled or inactive.
Setup logs can also replace the startup spinner before the agent starts the first prompt.
Changes
Loading.Failedstatus.Before:
flowchart LR A[Submit task] --> B[Starting task] B --> C[Queue status] C --> D[Sandbox status] D --> E[Conversation] classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff; classDef phYellow fill:#f9bd2b,stroke:#f9bd2b,color:#000; class A,E phBlue; class B,C,D phYellow;After:
flowchart LR A[Submit task] --> B[Loading] B --> C[First prompt] C --> D[Working] B --> E[Failed] classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff; classDef phRed fill:#f54e00,stroke:#f54e00,color:#fff; classDef phYellow fill:#f9bd2b,stroke:#f9bd2b,color:#000; class A,C,D phBlue; class B phYellow; class E phRed;No screenshot: the local Electron app did not finish booting in this sandbox.
How did you test this code?
Loading,Working,Failed, permissions, and standard spinner rendering.pnpm typecheckpackages/corenode scripts/check-host-boundaries.mjsuv run ./bin/hogli ci:preflight --strict👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Automatic notifications
Docs update
No docs change. This change only affects transient task status text and icons.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
/posthog-desktop,/writing-ui-components,/writing-user-facing-copy,/writing-tests,/writing-code-comments,/writing-simplified-technical-english,/qa-team,/dynamic-workflows,/running-ci-preflight,/test-electron-app, and/writing-pr-descriptions.Created with PostHog Desktop