Repository navigation
fix(desktop): restore the braille task spinner - #98087
Conversation
The sidebar and channel rows drew the standard arc spinner for a task that is loading or working. The dot ring reads as part of the dot column's vocabulary, so the marker returns to it. Restores the mark only. The startup and failed states it reports stay as they are. Generated-By: PostHog Desktop Task-Id: e964f68b-d4f7-4944-8dbd-0d9a34966c70
|
😎 Merged successfully - details. |
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
🤖 CI report✅ Trunk lane — non-backend lane (
|
Generated-By: PostHog Desktop Task-Id: e964f68b-d4f7-4944-8dbd-0d9a34966c70
HostHog preview —
|
|
Reviews (1): Last reviewed commit: "fix(desktop): put the dot ring back on t..." | Re-trigger Greptile |
There was a problem hiding this comment.
Approved.
Trivial, single-team UI fix by an author on the owning team, with test coverage and no risky territory touched.
- Author wrote 14% of the modified lines and has 5 merged PRs in these paths (familiarity MODERATE).
- 3 of the 3 changed files are governed by
products/desktop/AGENT_APPROVALS.md.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 11L, 2F substantive, 19L/3F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (19L, 3F, single-area, fix) |
| stamphog 2.0.0b4 | .stamphog/policy.yml @ 04438f4 · reviewed head 04438f4 |
Use the braille activity spinner for loading and working task markers. Generated-By: PostHog Desktop Task-Id: 9d1eb01b-9530-4792-b4c4-f250c7ce7484
A new stamphog review started for this PR — the fresh verdict replaces this approval.
There was a problem hiding this comment.
Not approved — escalated to a human reviewer.
Re-add the stamphog label to request another review once you have addressed this.
The PR description extensively describes restoring a "DotRingSpinner" ring mark with a whole revert-audit narrative, but the actual diff swaps in a different component (DotsCircleSpinner) rendering a braille-character animation, not a ring — the stated intent doesn't match the code change.
- Author wrote 14% of the modified lines and has 5 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
- 3 of the 3 changed files are governed by
products/desktop/AGENT_APPROVALS.md. - PR description claims restoration of 'DotRingSpinner' but diff imports and uses 'DotsCircleSpinner' with a braille-frame animation ('⠋'), not a dot ring — description and diff disagree on what visual component is being restored.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 9L, 2F substantive, 15L/3F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (15L, 3F, single-area, fix) |
| stamphog 2.0.0b4 | .stamphog/policy.yml @ f976cec · reviewed head f976cec |
Generated-By: PostHog Desktop Task-Id: 3e64512f-b700-4b0b-869c-ee3d70529738
|
Two automated findings, both checked and neither actionable here. React Doctor —
🦉 via talyn.dev |
There was a problem hiding this comment.
Approved.
Small, contained UI fix swapping one spinner component for another in the desktop task sidebar; tests updated to match, author is on the owning team, no risky territory.
- Author wrote 14% of the modified lines and has 5 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
- 3 of the 3 changed files are governed by
products/desktop/AGENT_APPROVALS.md.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 9L, 2F substantive, 15L/3F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (15L, 3F, single-area, fix) |
| stamphog 2.0.0b4 | .stamphog/policy.yml @ 0bdf075 · reviewed head 0bdf075 |
|
CI is green on
The PR still reads 🦉 via talyn.dev |
|
/trunk merge |
Problem
Working tasks use the generic loading spinner instead of the ASCII-style activity spinner used for agent work.
Source: original report.
Changes
The image uses a standalone render of the marker markup and CSS.
How did you test this code?
svgelement does.Automatic notifications
Docs update
None. The existing desktop conventions assign the braille spinner to agent activity.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
The agent updated this open pull request instead of opening a duplicate. The first revision used a dot ring. This revision uses the requested braille spinner.
A later session merged
masterinto the branch and re-ran CI.Tools used: PostHog Desktop coding agent, GitHub CLI, Vitest, TypeScript, Biome, and Playwright.
Skills invoked:
/posthog-desktop,/writing-ui-components,/writing-tests,/writing-code-comments,/running-ci-preflight, and/writing-pr-descriptions.Created with PostHog Desktop