Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The September 18 uprating changes had not been tested against the age-specific SPM forecast misses, and the saved housing-cap validation compared the model against a reference that omitted household subsidy allocation. This PR adds a dated, reproducible diagnostic for both questions.
The controlled comparison holds the population and all 84 non-country dependencies fixed, changing only PolicyEngine-US from
238321d3to44001a4c(#9526 and #9527, plus the intervening version bump). Six sequential runs cover 2024, 2025 and a 2025 threshold anchor in each arm.All recorded 2024 summaries match exactly. The fixes raise 2025 poverty by 0.121 pp overall, 0.170 pp for children and 0.051 pp for seniors. National and child point-estimate fit worsens; senior fit improves modestly but retains the opposite sign. This compares the controlled before arm with the after arm, not the original forecast runtime. Census's three observed annual changes are not statistically significant at 90% confidence.
The successor housing replay matches all 16 saved cases exactly at both native-unit and person levels. Census documentation supports household subsidy proration. The model's tenant-payment proxy remains an explicit assumption; matching this model contract does not establish Census parity or replace the original
NOT_REQUALIFIEDrecord.The analysis directory includes aggregate results, full-file and omitted-metadata hashes, exact installed-source verification receipts, dependency comparison, scripts, and reproduction instructions. The national-threshold decomposition labels the remainder as the change with national bases held constant in real terms, which includes resources, geography, composition and weights.
Validation:
These are explicitly uncertified development calculations: the released wrapper's data certificate does not cover the two country revisions. The original forecast and grade remain unchanged. No production model formula or app is changed.