Skip to content

Fix stale deduction and health-expense test fixtures #10221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hua7450 merged 1 commit into from
Oct 14, 2026
Merged

Fix stale deduction and health-expense test fixtures #10221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fix-main-ci-test-fixtures.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the deduction determinism test fixture and health-expense uprating expectations to reflect the current unemployment-compensation and premium inputs.
6 changes: 3 additions & 3 deletions policyengine_us/tests/core/test_ald_determinism.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,9 @@ def _probe_fixture(simulation):
"other_net_gain",
"limited_business_loss",
"capital_losses",
# MAGI reads all unemployment compensation, even when only its
# taxable portion is in the gross-income parameter list.
"unemployment_compensation",
# MAGI reads total reported or modeled unemployment compensation,
# even when only its taxable portion is in the gross-income list.
"total_unemployment_compensation",
"basic_income",
)
)
Expand Down
14 changes: 4 additions & 10 deletions policyengine_us/tests/core/test_cms_moop_uprating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,15 @@
TABLE_YEARS = range(FIRST_TABLE_YEAR, LAST_PROJECTED_YEAR + 1)
ACCOUNT_YEARS = range(FIRST_YEAR, FIRST_PROJECTED_YEAR)
# Health expense inputs that uprate by this series, as listed in
# docs-quarto/methodology/spm-poverty.qmd. Pre-tax health insurance premiums
# also use it today; PR #10083 moves them to the ESI premium series, so they
# are left out here. HSA payroll contributions follow the family HSA
# contribution limit since #10097.
# docs-quarto/methodology/spm-poverty.qmd. Premiums follow separate series,
# covered by test_premium_input_uprating.py. HSA payroll contributions follow
# the family HSA contribution limit.
HEALTH_INPUTS = {
"ambulance_expense",
"er_visit_expense",
"health_insurance_premiums",
"health_insurance_premiums_without_medicare_part_b",
"imaging_expense",
"inpatient_expense",
"lab_expense",
"long_term_health_insurance_premiums",
"medicare_part_b_premiums_reported",
"other_health_insurance_premiums",
"other_medical_expenses",
"outpatient_expense",
"over_the_counter_health_expenses",
Expand Down Expand Up @@ -265,4 +259,4 @@ def test_health_inputs_uprate_by_the_cms_series():
users = {
name for name, variable in system.variables.items() if variable.uprating == MOOP
}
assert users - {"pre_tax_health_insurance_premiums"} == HEALTH_INPUTS
assert users == HEALTH_INPUTS
Loading