Repository navigation
Fix stale deduction and health-expense test fixtures - #10221
Merged
Merged
Conversation
MaxGhenis
added a commit
that referenced
this pull request
Oct 14, 2026
Take main's determinism-test fixture from #10221 (total_unemployment_compensation only); none of the probed formulas read unemployment_compensation directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fix two stale tests that fail on current
mainand in PR #9687 (failing main job).total_unemployment_compensationin the isolated deduction determinism fixture. The student-loan MAGI formula reads that variable after Integrate modeled state unemployment insurance into income flows #9558, but the fixture introduced in Give each spouse their own above-the-line deductions in per-person AGI #9890 still supplied onlyunemployment_compensation. Keep the full-model oracle and comparisons across six hash seeds.This changes tests and the changelog only; model behavior is unchanged.
Test plan
mainat654a0c9b54a57e6422f4d0418d0d039a3bb3537cbefore the fix.test_ald_determinism.py,test_cms_moop_uprating.py, andtest_premium_input_uprating.py, using Python 3.14.6 and PolicyEngine Core 3.33.3 (the Core version used by the failing CI jobs).make format(withUV_NO_SYNC=1to retain the CI Core version in the local environment).changelog.d/.axiom: n/a: test fixture and expectation updates only; no policy behavior changes.