Skip to content

Omit null optional fields from Modal worker payloads #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGhenis merged 1 commit into from
Apr 26, 2026
+4 −0
Merged

Omit null optional fields from Modal worker payloads #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/policyengine-api-simulation/src/modal/gateway/endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ def _build_budget_window_parent_payload(
payload = request.model_dump(
exclude={"telemetry"},
mode="json",
exclude_none=True,
)
payload["version"] = resolved_version
if request.telemetry is not None:
Expand Down Expand Up @@ -162,6 +163,7 @@ async def submit_simulation(request: SimulationRequest):
payload = request.model_dump(
exclude={"version", "telemetry"},
mode="json",
exclude_none=True,
)
run_id = request.telemetry.run_id if request.telemetry else None
if request.telemetry is not None:
Expand Down
2 changes: 2 additions & 0 deletions projects/policyengine-api-simulation/tests/gateway/test_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ def test__given_no_data_value__then_routes_to_run_simulation(
"policyengine-simulation-us1-500-0-uk2-66-0",
"run_simulation",
)
assert "time_period" not in mock_modal["func"].last_payload
assert "data_version" not in mock_modal["func"].last_payload

def test__given_submission__then_returns_job_id_and_poll_url(
self, mock_modal, client: TestClient
Expand Down
Loading