Omit null optional fields from Modal worker payloads#469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude_none=Truewhen the gateway forwards simulation and budget-window payloads to Modal worker functions.time_periodanddata_versionare not forwarded as explicitnullvalues.Why
The main deploy after #468 reached the worker but beta integration still failed because the gateway sent
time_period: null. The current workerSimulationOptionsrejectsNonefortime_period; omitting absent optional values preserves the worker default behavior.Testing
env -u UV_FROZEN uv run pytest tests/gateway/test_endpoints.py -qenv -u UV_FROZEN uv run pytest -qenv -u UV_FROZEN uv run --with ruff ruff format --check src