Rebrand Puppet -> OpenVox and fix links - #530
Conversation
|
For file paths I'd really like #225 to go in first. It makes it a lot easier. |
Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Rebrand remaining user-facing product references throughout lib/, docs/, api/, conf/, ext/, examples/, and rakelib/: CLI help text, setting descriptions, type/provider/function docstrings, and log messages. Ruby namespaces, the puppet executable and subcommands, the Puppet language/DSL, literal paths/routes/service names, and Puppet Forge references are unchanged. Protocol-visible literals (User-Agent, X-Puppet-* headers, SSL OID display names, log source names) are kept to preserve wire and tooling compatibility. Also: - Remove Puppet Enterprise references - Rebrand prose Facter -> OpenFact and PuppetDB -> OpenVoxDB - Map puppet.com/docs/puppet links to docs.openvoxproject.org/openvox and puppet.com/docs/puppetserver links to .../openvox-server - Fix "a OpenVox" -> "an OpenVox" - Regenerate man pages, references, and locales/puppet.pot - Convert man pages with pandoc directly in references:man; pandoc-ruby fails with EPIPE under pandoc 3.x - Use /openvox/latest canonical paths in generated references - Update spec expectations for the new strings Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
This change explicitly does not touch file paths. |
Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Rebrand user-facing product references, following the treatment of OpenVoxProject/openvox#530: - Facter -> OpenFact and Puppet -> OpenVox in README, Extensibility.md, CONTRIBUTING.md, docs/data-flow.md, code comments, docstrings, the --puppet CLI option description, fact schema descriptions, and log/warning message text (plus the matching spec expectation) - puppet-agent -> openvox-agent where the AIO package is meant in prose - Rewrite puppet.com documentation links to docs.openvoxproject.org Deliberately unchanged: the facter executable and man page command name, Facter/LegacyFacter Ruby namespaces and API, fact and resolver names, environment variables, file paths, registry keys, references to the Puppet language/DSL and manifests, comparisons with upstream Facter releases (Facter 3/4), copyright and license attributions, CHANGELOG/HISTORY entries, and the generated man page (regenerate via rake gen_manpages). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steve@sicura.us>
Apply the same treatment as OpenVoxProject/openvox#530 to user-facing prose in this repository: - Rebrand "Puppet Server" -> "OpenVox Server" and "Puppet" (the product) -> "OpenVox" in the README, documentation pointer, shipped and dev config file comments, Clojure docstrings and comments, Java and embedded Ruby comments, and log/warning messages (including i18n/trs strings; the locales/*.pot catalog will need regeneration). - Rebrand prose Facter -> OpenFact and puppet-agent (AIO package) -> openvox-agent where they name the product in comments. - Neutralize the remaining Puppet Enterprise reference. - Point documentation/README.md at https://docs.openvoxproject.org/openvox-server/latest/. - Update RSpec and clojure.test assertions/descriptions that reference the changed strings, plus the acceptance check for the startup log message. Deliberately unchanged: the puppetserver CLI/service/package name, Clojure namespaces and service/protocol names, HTTP API routes and X-Puppet-* headers, config file names/settings and file paths, Ruby Puppet:: namespaces and Puppet[:setting] code, the "Puppet Server Internal Certificate" Netscape comment value embedded in certificates, Puppet Labs OID attribution, historical version references (Puppet 3.x/4/6/8, Puppet Server 2.0/2.1), Puppet language/DSL references, CHANGELOG, LICENSE/copyright lines, generated locale catalogs, and the legacy upstream-targeting acceptance harness. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steve@sicura.us>
Rebrand user-facing product references, following the treatment of OpenVoxProject/openvox#530: - Facter -> OpenFact and Puppet -> OpenVox in README, Extensibility.md, docs/data-flow.md, code comments, docstrings, the --puppet CLI option description, fact schema descriptions, and log/warning message text (plus the matching spec expectation) - puppet-agent -> openvox-agent where the AIO package is meant in prose - Rewrite puppet.com documentation links to docs.openvoxproject.org - Point CONTRIBUTING.md at the OpenVoxProject contribution documents - Update author/email/homepage packaging metadata in ext/project_data.yaml to the OpenVox Project, matching openfact.gemspec - Regenerate the man page with rake gen_manpages Deliberately unchanged: the facter executable and man page command name, Facter/LegacyFacter Ruby namespaces and API, fact and resolver names, environment variables, file paths, registry keys, references to the Puppet language/DSL and manifests, comparisons with upstream Facter releases (Facter 3/4), copyright and license attributions, and CHANGELOG/HISTORY entries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steve@sicura.us>
trefzer
left a comment
There was a problem hiding this comment.
I approve. Thanks for all the work !
Many of my review comments are duplicate things, none of them is blocking.
But it's probably a good idea to rapidly scroll through them before mergin.
| and 4.x. However, Rack masters, WEBrick masters, and Puppet Server 2.0 cannot | ||
| and 4.x. However, Rack servers, WEBrick servers, and Puppet Server 2.0 cannot | ||
| serve nodes running Puppet 3.x. | ||
|
|
There was a problem hiding this comment.
^ this seems to be very old ! is this still needed ?
|
|
||
| Puppet only trusts the puppet PKI when connecting to puppet infrastructure, but | ||
| OpenVox only trusts the puppet PKI when connecting to puppet infrastructure, but | ||
| needs to additionally trust the system cert store for requests like PMT and |
There was a problem hiding this comment.
I think in line 88 the two puppet occurance should also change to openvox
| such as the [puppetdb | ||
| terminus](https://github.com/puppetlabs/puppetdb/blob/6.5.0/puppet/lib/puppet/util/puppetdb/http.rb#L138), | ||
| PE classifier terminus, and ['http' report | ||
| terminus](https://github.com/puppetlabs/puppetdb/blob/6.5.0/puppet/lib/puppet/util/puppetdb/http.rb#L138) |
There was a problem hiding this comment.
These github links to puppetdb should probably also better be linked to openvoxdb. but leaving for now is ok for me.
|
|
||
| Puppet is a beast. Puppet is at times a very *slow* beast. Maybe we can find | ||
| OpenVox is a beast. OpenVox is at times a very *slow* beast. Maybe we can find | ||
| what is making it slow and fix it. |
| hash from a password. | ||
| * Mac OS X 10.7 (Lion), and many recent Linux distributions, use salted SHA512 | ||
| hashes. The Puppet Labs [stdlib][] module contains a `str2saltedsha512` function | ||
| hashes. The puppetlabs [stdlib][] module contains a `str2saltedsha512` function |
| @@ -4758,7 +4778,7 @@ To use the `forcelocal` parameter, you need to install the `libuser` package (pr | |||
| `/usr/sbin/lgroupadd` and `/usr/sbin/luseradd`). | |||
|
|
|||
| * Required binaries: `chage`, `chpasswd`, `lchage`, `luseradd`, `luserdel`, `lusermod`, `useradd`, `userdel`, `usermod`. | |||
| * Supported features: `allows_duplicates`, `manages_expiry`, `manages_homedir`, `manages_shell`, `system_users`. | |||
| * Supported features: `allows_duplicates`, `manages_expiry`, `manages_homedir`, `manages_local_users_and_groups`, `manages_shell`, `system_users`. | |||
|
|
|||
| As the OpenVox project matures, we will create more documentation, guides, and tutorials. | ||
| For the time being though, now you’ll want to hop over to [Puppet’s own documentation](https://puppet.com/docs) and go from there. | ||
| For the time being though, now you’ll want to hop over to [the OpenVox documentation](https://docs.openvoxproject.org/) and go from there. | ||
|
|
There was a problem hiding this comment.
lol ;) This does not make sense, either keep puppetlabs url, or rephrase the sentence.
Fixes for the unresolved review comments on the rebranding PR: - README: rephrase the documentation paragraph that contradicted itself after the link was repointed at docs.openvoxproject.org - docs/http.md: rebrand remaining PKI/infrastructure prose; point the puppetdb terminus and http report processor links at the OpenVoxProject repos - docs/rspec_tutorial.md: drop the stale "(spec tests only)" qualifier - docs/unicode.md: drop the obsolete Ruby 1.9 framing - api/docs/http_api_index.md: remove the stale Puppet Server 2.x / agent 3.x-4.x compatibility paragraph - defaults.rb: reference `serverport` instead of the deprecated masterport name in the server_list description; say "OpenVox Server" instead of the nonexistent `puppet server` command; drop the obsolete pre-7.x Windows version note from manage_internal_file_permissions - application help: clearer wording for the agent SIGHUP/SIGTERM signal descriptions and the apply "site-wide manifests" sentence; punctuate the dual Puppet Inc./Vox Pupuli copyright notices so they read correctly when man pages join the lines - user type: inline the stdlib module link so it is visible in the rendered attribute docs - module_loaders.rb, resource_type_impl.rb: reword comments/messages flagged as unclear - reference templates: fix canonical paths still pointing at /puppet/latest, use https for the Forge link, name the openvox-agent package explicitly (with matching anchors), and replace the broken core-types-cheatsheet reference link - locales/config.yaml: OpenVox package name, GitHub issues as the bug address, and dual Vox Pupuli / Puppet Inc. copyright - Regenerate man pages, references, and locales/puppet.pot Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Fixes for the unresolved review comments on the rebranding PR: - README: rephrase the documentation paragraph that contradicted itself after the link was repointed at docs.openvoxproject.org - docs/http.md: rebrand remaining PKI/infrastructure prose; point the puppetdb terminus and http report processor links at the OpenVoxProject repos - docs/rspec_tutorial.md: drop the stale "(spec tests only)" qualifier - docs/unicode.md: drop the obsolete Ruby 1.9 framing - api/docs/http_api_index.md: remove the stale Puppet Server 2.x / agent 3.x-4.x compatibility paragraph - defaults.rb: reference `serverport` instead of the deprecated masterport name in the server_list description; say "OpenVox Server" instead of the nonexistent `puppet server` command; drop the obsolete pre-7.x Windows version note from manage_internal_file_permissions - application help: clearer wording for the agent SIGHUP/SIGTERM signal descriptions and the apply "site-wide manifests" sentence; punctuate the dual Puppet Inc./Vox Pupuli copyright notices so they read correctly when man pages join the lines - user type: inline the stdlib module link so it is visible in the rendered attribute docs - module_loaders.rb, resource_type_impl.rb: reword comments/messages flagged as unclear - reference templates: fix canonical paths still pointing at /puppet/latest, use https for the Forge link, name the openvox-agent package explicitly (with matching anchors), and replace the broken core-types-cheatsheet reference link - locales/config.yaml: OpenVox package name, GitHub issues as the bug address, and dual Vox Pupuli / Puppet Inc. copyright - Regenerate man pages, references, and locales/puppet.pot Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Address review feedback from #530
Short description
Follow-up to #348 to fix OpenVox branding and links
Rebrand remaining user-facing product references throughout
lib/,docs/,api/,conf/,ext/,examples/, andrakelib/: CLI help text, settingdescriptions, type/provider/function docstrings, and log messages.
Ruby namespaces, the puppet executable and subcommands, the Puppet
language/DSL, literal paths/routes/service names, and Puppet Forge
references are unchanged. Protocol-visible literals (
User-Agent,X-Puppet-*headers, SSL OID display names, log source names) are keptto preserve wire and tooling compatibility.
Also:
and puppet.com/docs/puppetserver links to .../openvox-server
locales/puppet.potpandocdirectly inreferences:man;pandoc-rubyfails with
EPIPEunder pandoc 3.x/openvox/latestcanonical paths in generated referencesAssisted by Claude Code
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent