Skip to content

Address review feedback from #530 - #579

Merged
silug merged 1 commit into
OpenVoxProject:mainfrom
silug:pr530-followup
Aug 3, 2026
Merged

Address review feedback from #530#579
silug merged 1 commit into
OpenVoxProject:mainfrom
silug:pr530-followup

Conversation

@silug

@silug silug commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Short description

Fixes for the unresolved review comments on the rebranding PR:

  • README: rephrase the documentation paragraph that contradicted itself after the link was repointed at docs.openvoxproject.org
  • docs/http.md: rebrand remaining PKI/infrastructure prose; point the puppetdb terminus and http report processor links at the OpenVoxProject repos
  • docs/rspec_tutorial.md: drop the stale "(spec tests only)" qualifier
  • docs/unicode.md: drop the obsolete Ruby 1.9 framing
  • api/docs/http_api_index.md: remove the stale Puppet Server 2.x / agent 3.x-4.x compatibility paragraph
  • defaults.rb: reference serverport instead of the deprecated masterport name in the server_list description; say "OpenVox Server" instead of the nonexistent puppet server command; drop the obsolete pre-7.x Windows version note from manage_internal_file_permissions
  • application help: clearer wording for the agent SIGHUP/SIGTERM signal descriptions and the apply "site-wide manifests" sentence; punctuate the dual Puppet Inc./Vox Pupuli copyright notices so they read correctly when man pages join the lines
  • user type: inline the stdlib module link so it is visible in the rendered attribute docs
  • module_loaders.rb, resource_type_impl.rb: reword comments/messages flagged as unclear
  • reference templates: fix canonical paths still pointing at /puppet/latest, use https for the Forge link, name the openvox-agent package explicitly (with matching anchors), and replace the broken core-types-cheatsheet reference link
  • locales/config.yaml: OpenVox package name, GitHub issues as the bug address, and dual Vox Pupuli / Puppet Inc. copyright
  • Regenerate man pages, references, and locales/puppet.pot

Generated by Claude Code

Checklist

I have:

Comment thread man/man5/puppet.conf.5
@silug silug mentioned this pull request Aug 1, 2026
8 tasks
Fixes for the unresolved review comments on the rebranding PR:

- README: rephrase the documentation paragraph that contradicted itself
  after the link was repointed at docs.openvoxproject.org
- docs/http.md: rebrand remaining PKI/infrastructure prose; point the
  puppetdb terminus and http report processor links at the
  OpenVoxProject repos
- docs/rspec_tutorial.md: drop the stale "(spec tests only)" qualifier
- docs/unicode.md: drop the obsolete Ruby 1.9 framing
- api/docs/http_api_index.md: remove the stale Puppet Server 2.x / agent
  3.x-4.x compatibility paragraph
- defaults.rb: reference `serverport` instead of the deprecated
  masterport name in the server_list description; say "OpenVox Server"
  instead of the nonexistent `puppet server` command; drop the obsolete
  pre-7.x Windows version note from manage_internal_file_permissions
- application help: clearer wording for the agent SIGHUP/SIGTERM
  signal descriptions and the apply "site-wide manifests" sentence;
  punctuate the dual Puppet Inc./Vox Pupuli copyright notices so they
  read correctly when man pages join the lines
- user type: inline the stdlib module link so it is visible in the
  rendered attribute docs
- module_loaders.rb, resource_type_impl.rb: reword comments/messages
  flagged as unclear
- reference templates: fix canonical paths still pointing at
  /puppet/latest, use https for the Forge link, name the openvox-agent
  package explicitly (with matching anchors), and replace the broken
  core-types-cheatsheet reference link
- locales/config.yaml: OpenVox package name, GitHub issues as the bug
  address, and dual Vox Pupuli / Puppet Inc. copyright
- Regenerate man pages, references, and locales/puppet.pot

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
@silug
silug merged commit 4b50e73 into OpenVoxProject:main Aug 3, 2026
16 checks passed
@silug
silug deleted the pr530-followup branch August 3, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants