Address review feedback from #530 - #579
Merged
Merged
Conversation
bastelfreak
reviewed
Aug 1, 2026
Fixes for the unresolved review comments on the rebranding PR: - README: rephrase the documentation paragraph that contradicted itself after the link was repointed at docs.openvoxproject.org - docs/http.md: rebrand remaining PKI/infrastructure prose; point the puppetdb terminus and http report processor links at the OpenVoxProject repos - docs/rspec_tutorial.md: drop the stale "(spec tests only)" qualifier - docs/unicode.md: drop the obsolete Ruby 1.9 framing - api/docs/http_api_index.md: remove the stale Puppet Server 2.x / agent 3.x-4.x compatibility paragraph - defaults.rb: reference `serverport` instead of the deprecated masterport name in the server_list description; say "OpenVox Server" instead of the nonexistent `puppet server` command; drop the obsolete pre-7.x Windows version note from manage_internal_file_permissions - application help: clearer wording for the agent SIGHUP/SIGTERM signal descriptions and the apply "site-wide manifests" sentence; punctuate the dual Puppet Inc./Vox Pupuli copyright notices so they read correctly when man pages join the lines - user type: inline the stdlib module link so it is visible in the rendered attribute docs - module_loaders.rb, resource_type_impl.rb: reword comments/messages flagged as unclear - reference templates: fix canonical paths still pointing at /puppet/latest, use https for the Forge link, name the openvox-agent package explicitly (with matching anchors), and replace the broken core-types-cheatsheet reference link - locales/config.yaml: OpenVox package name, GitHub issues as the bug address, and dual Vox Pupuli / Puppet Inc. copyright - Regenerate man pages, references, and locales/puppet.pot Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
bastelfreak
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Fixes for the unresolved review comments on the rebranding PR:
serverportinstead of the deprecated masterport name in the server_list description; say "OpenVox Server" instead of the nonexistentpuppet servercommand; drop the obsolete pre-7.x Windows version note from manage_internal_file_permissionsGenerated by Claude Code
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent