Skip to content

Fix the report authorization test's is_pe? misfire #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silug wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −8
Open

Fix the report authorization test's is_pe? misfire #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions acceptance/suites/tests/authorization/default_rules.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,14 @@ def report_query(node)
assert_allowed(stdout)
end

# In PE, the master (specifically the orchestrator)
# is allowed to make report submissions on behalf of
# other nodes
# Nodes may submit only their own reports (allow: "$1"); submitting on
# behalf of other nodes was a PE orchestrator capability that OpenVox
# does not have. Note: this must not be guarded on master.is_pe? --
# this suite's beaker options do not set a host type, and beaker's
# default type is 'pe', which made is_pe? return true on FOSS hosts
# and select the wrong assertion.
curl_authenticated(report_query('notme')) do |stdout|
if master.is_pe?
assert_allowed(stdout)
else
assert_denied(stdout, /\/puppet\/v3\/report\/notme \(method :put\)/)
end
assert_denied(stdout, /\/puppet\/v3\/report\/notme \(method :put\)/)
end

curl_unauthenticated(report_query(masterfqdn)) do |stdout|
Expand Down