Fix the report authorization test's is_pe? misfire - #557
Open
silug wants to merge 1 commit into
Open
Conversation
The report/notme step asserted that the primary may submit reports on behalf of other nodes when master.is_pe? is true. This suite's beaker options do not set a host type, and beaker's default type is 'pe', so is_pe? returned true on every FOSS host and selected the PE assertion -- which the shipped allow: "$1" report rule correctly rejects with 403. This is the step where default_rules.rb actually failed in acceptance run 31098859281, before the filebucket assertions were ever reached. OpenVox has no PE edition, so drop the PE arm and assert the denial unconditionally, with a comment warning against reintroducing is_pe? guards while the suite's host type is unset. Verified on a local beaker rig against openvox-server 9.0.0~beta4: the unmodified test fails at report/notme exactly as in the pipeline; with this commit plus the filebucket fix already on this branch, default_rules.rb passes end to end (including the new agent-cert filebucket denial and primary-cert 404 assertions). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The report/notme step asserted that the primary may submit reports on behalf of other nodes when master.is_pe? is true. This suite's beaker options do not set a host type, and beaker's default type is 'pe', so is_pe? returned true on every FOSS host and selected the PE assertion -- which the shipped allow: "$1" report rule correctly rejects with 403. This is the step where default_rules.rb actually failed in acceptance run 31098859281, before the filebucket assertions were ever reached.
OpenVox has no PE edition, so drop the PE arm and assert the denial unconditionally, with a comment warning against reintroducing is_pe? guards while the suite's host type is unset.
Verified on a local beaker rig against openvox-server 9.0.0~beta4: the unmodified test fails at report/notme exactly as in the pipeline; with this commit plus the filebucket fix in #556, default_rules.rb passes end to end (including the new agent-cert filebucket denial and primary-cert 404 assertions).
Generated by Claude Code
This Pull Request (PR) fixes the following issues
N/A