Skip to content

Make AttributeBodyVisitor visit mutating #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 1 commit into from
Apr 28, 2026
Merged

Make AttributeBodyVisitor visit mutating #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/OpenAttributeGraph/Attribute/Body/AttributeBodyVisitor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
// Status: WIP

public protocol AttributeBodyVisitor {
func visit<Body: _AttributeBody>(body: UnsafePointer<Body>)
mutating func visit<Body: _AttributeBody>(body: UnsafePointer<Body>)
Copy link
Copy Markdown

@augmentcode augmentcode Bot Apr 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sources/OpenAttributeGraph/Attribute/Body/AttributeBodyVisitor.swift:8 — With visit now mutating, any struct/enum conformers must also mark their implementation as mutating or they will no longer satisfy AttributeBodyVisitor (e.g., the Visitor in Tests/OpenAttributeGraphCompatibilityTests/Attribute/Attribute/AnyAttributeCompatibilityTests.swift). Consider ensuring internal/downstream conformers are updated accordingly.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

}
1 change: 0 additions & 1 deletion Sources/OpenAttributeGraphShims/Adapter/DanceUIGraph.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
@_exported public import DanceUIRuntime
@_exported public import DanceUIGraph

public typealias AttributeBodyVisitor = DanceUIGraph.AttributeBodyVisitor
public typealias ComparisonMode = DGComparisonMode
public typealias GraphContext = DGGraphContextRef
public typealias Metadata = DGTypeID
Expand Down
Loading