Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 31.08% 32.10% +1.02%
==========================================
Files 71 71
Lines 2635 2601 -34
==========================================
+ Hits 819 835 +16
+ Misses 1816 1766 -50
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🤖 Augment PR SummarySummary: Makes 🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| public protocol AttributeBodyVisitor { | ||
| func visit<Body: _AttributeBody>(body: UnsafePointer<Body>) | ||
| mutating func visit<Body: _AttributeBody>(body: UnsafePointer<Body>) |
There was a problem hiding this comment.
Sources/OpenAttributeGraph/Attribute/Body/AttributeBodyVisitor.swift:8 — With visit now mutating, any struct/enum conformers must also mark their implementation as mutating or they will no longer satisfy AttributeBodyVisitor (e.g., the Visitor in Tests/OpenAttributeGraphCompatibilityTests/Attribute/Attribute/AnyAttributeCompatibilityTests.swift). Consider ensuring internal/downstream conformers are updated accordingly.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
0a15268 to
bd7d729
Compare
Summary
AttributeBodyVisitor.visitasmutatingso visitor implementations can keep state while traversing attribute bodies.