Repository navigation
fix: streams above 1080p in the single view (#166) - #220
Draft
compot-dev wants to merge 6 commits into
Draft
compot-dev wants to merge 6 commits into
compot-dev wants to merge 6 commits into
Conversation
compot-dev
added a commit
that referenced
this pull request
Oct 16, 2026
1 task done
compot-dev
added a commit
that referenced
this pull request
Oct 16, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166 (to be confirmed on the reporter's HY300).
Problem. On a Rockchip HY300 (Android 11,
OMX.rk.video_decoder.avc/hevc) a 2304×1296 stream connects, the decoder starts and allocates buffers, but never outputs a frame (no "Resolution update" in the log). 1080p from the same camera plays.Cause (likely). The decoder is always configured at 1280×720 and learns the real size from the stream. With adaptive playback some hardware decoders only allocate for the configured maximum, so a picture above 1080p never comes out.
Change. In the single view the decoder is told the largest picture it supports, via
KEY_MAX_WIDTH/KEY_MAX_HEIGHT(the first supported of 3840×2160, 2560×1920, 2560×1440, 2304×1296). The log saysDecoder <name>: pictures up to W×H. The grid stays as before: nine decoders with 4K buffers would not fit in memory.Version 2.17 (2.15 and 2.16 went to the toy drone PRs #215 and #224; 2.14 was the test build hy300-166-test1).
pictures up to 3840×2160), 1080p H.264 at 20 fps, grid unchanged, no crash