Repository navigation
feat: per-slot Turn in the camera settings, H.264/H.265 turned by the decoder (#201) - #225
Draft
compot-dev wants to merge 4 commits into
Draft
compot-dev wants to merge 4 commits into
compot-dev wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #201. Version 2.18 (2.17 is #220).
?rotate=and the toys' defaults.MediaFormat.KEY_ROTATION, Android 6+), MJPEG by the hardware JPEG decoder the same way, or while drawing on the software path.?rotate=now works for every codec.Checked on Aceline-1: 90° on a 1080p H.264 camera in the single view (shown 1080×1920, pillarboxed) and in a grid cell; the settings dialog works with the remote and touch. The turn costs no frame rate there.
Not done yet:
Mirror:
setScaleX(-1)on the SurfaceView does not mirror the picture on the AG-216, so it is left out; mirroring a hardware decoder's output needs a GL path.Snapshots/screenshots: the debug snapshot of a turned slot came out turned by 180° in a test; it looks like PixelCopy already applies the decoder's turn, so the extra turn in
Snapshots(this PR) is probably wrong. To be checked once more and fixed before un-drafting.Snapshot and long-press screenshot follow the turn
Aceline-1: 0/90/180/270 in the single view and the grid