Repository navigation
fix: WebUI — on-screen keyboard for the camera's text fields (#120) - #122
Merged
Merged
Conversation
Collaborator
Author
|
/review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn these tips off under Display > Comment parts Previous reviewsReview updated until commit dca2ade Results up to commit N/ASorry, something went wrongWe weren't able to complete the code review on our side. Please try again manually by commenting /agentic_review on this PR.
|
4 of 7 tasks
Collaborator
Author
|
/agentic_review |
Code Review by QodoSorry, something went wrongWe weren't able to complete the code review on our side. Please try again manually by commenting/agentic_review on this PR.
|
compot-dev
force-pushed
the
fix/webui-keyboard
branch
from
October 13, 2026 11:56
4ee6a77 to
dca2ade
Compare
Collaborator
Author
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit dca2ade |
compot-dev
added a commit
that referenced
this pull request
Oct 15, 2026
fix: WebUI — on-screen keyboard for the camera's text fields (#120)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120.
Cause: WebUI shows the camera's page in a WebView inside an
AlertDialog. AlertDialog setsFLAG_ALT_FOCUSABLE_IMon its window when its content has noEditText— a WebView does not count — so the input method is never shown for that window: tapping a password field of the page does nothing. In a browser the same page works.Fix: after
show(), clearFLAG_NOT_FOCUSABLE | FLAG_ALT_FOCUSABLE_IM, useSOFT_INPUT_ADJUST_RESIZE(the page stays visible above the keyboard), and make the WebView focusable (also in touch mode) and focused.Device check: phone (touch) — tap a field in WebUI → keyboard; TV box — the field gets the focus with the remote and the TV keyboard opens.