Merge pull request #122 from OpenIPC/fix/webui-keyboard

fix: WebUI — on-screen keyboard for the camera's text fields (#120)

Author: compot-dev

android/app/src/main/java/com/openipc/decoder/MenuManager.java

@@ -530,6 +530,18 @@ public void onReceivedHttpAuthRequest(
         });
         mBrowserDialog = dialog;
         dialog.show();
+        // AlertDialog marks its window "no input method" when its content has no EditText,
+        // and a WebView is not one: text fields of the camera's page then got no keyboard
+        // (#120). Clear that, and let the page take the focus for its fields
+        android.view.Window w = dialog.getWindow();
+        if (w != null) {
+            w.clearFlags(WindowManager.LayoutParams.FLAG_NOT_FOCUSABLE
+                    | WindowManager.LayoutParams.FLAG_ALT_FOCUSABLE_IM);
+            w.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE);
+        }
+        view.setFocusable(true);
+        view.setFocusableInTouchMode(true);
+        view.requestFocus(View.FOCUS_DOWN);
         view.loadUrl(scheme + "://" + link);
     }
 

android/app/src/test/java/com/openipc/decoder/CredentialStoreTest.java

@@ -83,7 +83,9 @@ public void undecryptableValueBecomesAnEmptySlot() throws Exception {
         // Another key (e.g. data restored on another device)
         assertNull(new CredentialStore(new TestCipher()).open(sealed));
         // Tampered or truncated data
-        assertNull(store.open(sealed.substring(0, sealed.length() - 2) + "00"));
+        // Change the last two characters for sure: "00" could be the original ones (1 in 256)
+        String tail = sealed.endsWith("00") ? "ff" : "00";
+        assertNull(store.open(sealed.substring(0, sealed.length() - 2) + tail));
         assertNull(store.open(CredentialStore.PREFIX + "zz"));
         assertNull(store.open(CredentialStore.PREFIX + "abc"));
     }