Improve interface details - #3794
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3794 +/- ##
==========================================
+ Coverage 79.13% 79.21% +0.08%
==========================================
Files 894 894
Lines 66865 66984 +119
Branches 2551 2600 +49
==========================================
+ Hits 52911 53061 +150
+ Misses 13293 13263 -30
+ Partials 661 660 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| | port | Integer | Port the server listens on | | ||
| | request_queue_length | Integer | Number of requests queued to be read | | ||
| </TabItem> | ||
| </Tabs> |
There was a problem hiding this comment.
I think all this info is great, I just worry about it becoming out of date with changes to the underlying protocols. Luckily we rarely change these so there's not much chance for drift but we have to remember to update this.
There was a problem hiding this comment.
It would probably be good to add a line to our AI instructions file (which we should probably migrate to agents.md) to check if there is documentation and update it, at least when modifying any of the functions that can be used in scripts or microservices



What changed
detailsinstead of crashing scriptinterface_detailsto documentation (Claude generated)detailsto "Custom Interfaces" documentationWhy it changed
Support email about custom interface crashing when calling
interface_detailson it, digging deeper into how this function works and what it callsTesting strategy
mainvs on this branchmain, editsimulated_target_interface.pyto have the implementation ofdetailsmethodopenc3.sh startResult
on
main: interface crashes and reboots, see logs and connected status of INST2on this branch: error logged, interface does not crash/reboot
Review notes
A lot was added to the documentation detailing the return format of
interface_detailswith both common keys and interface-specific keys. They are tabbed so that not all information is shown at once, but it is a lot of lines and still a fairly large section on the docs page. Details about what is returned is a big hole in the documentation, and it is possible that this opens a can of worms, but this feels like one of the most complex returns of methods that are offered to users.