fix(test): stop asserting exact elapsed time in wait timeout tests - #3795
Merged
Merged
Conversation
Timeout assertions matched the printed elapsed seconds against the timeout value (e.g. "after waiting 0.1"), which fails on slow CI runners where the poll loop overshoots (observed 0.242s on Python 3.14). Drop the elapsed value from the assertions, matching the existing style in test_waits_for_a_logical_expression. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3795 +/- ##
==========================================
- Coverage 79.17% 79.16% -0.01%
==========================================
Files 894 894
Lines 66949 66949
Branches 2600 2552 -48
==========================================
- Hits 53009 53003 -6
- Misses 13276 13283 +7
+ Partials 664 663 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
calmonroe
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed the exact elapsed-time value from four timeout assertions in
openc3/python/test/api/test_api_shared.py. They now assert on"... after waiting"instead of"... after waiting 0.1".Why it changed
TestApiShared::test_waits_for_an_expressionfailed on the Python 3.14 job of run 33422678518:The assertions compared the printed elapsed seconds against the requested timeout. On a slow runner the polling loop overshoots the timeout, so the printed value (0.242) no longer starts with the timeout value (0.1). The elapsed time is not what these tests are verifying — the sibling
test_waits_for_a_logical_expressionalready asserts without the number.This is a pre-existing flake on
main, not introduced by #3794.Testing strategy
uv run pytest test/api/test_api_shared.py— 44 passed.🤖 Generated with Claude Code