fix: require an Octopus space instead of falling back to Default by matt-richardson · Pull Request #287 · OctopusDeploy/Octopus-TeamCity

matt-richardson · 2026-10-27T02:39:53Z

Merges into #276.

A step with no space, on the step or its connection, sent --space Default. The legacy CLI left --space out and used the server's real default space. An instance whose default space was renamed or deleted would fail, or act on the wrong space. The Go CLI can't leave the flag out: run non-interactively, it errors with "space must be specified when not running interactively". So the space is now required, rather than guessed.

Notes:

A step that doesn't use a connection can't be saved without a space.
A connection's space stays optional, so one connection can serve steps in different spaces. The step form can't see the connection's settings when it validates. A step whose connection has no space, and that names no space itself, fails at build time with "No Octopus space is set" before any CLI command runs.
TeamCity runs the same check when it matches a build to an agent. A saved step with no space and no connection makes every agent incompatible, so the build stays queued. The agent's compatibility details show "Space must be specified". feat!: Remove legacy CLI and default new Go CLI #276's release notes should mention this.
The pack step doesn't talk to Octopus and doesn't need a space.
The e2e tests that ran builds against a connection with a blank space now set Default.

🤖 Generated with Claude Code

The Go CLI archives are now downloaded at build time (#282). Drop the committed cli/ archives and point downloadOctopusCli at resources/cli/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Bring in the per-architecture Go CLI archives (#283). Port the architecture lookup into cli/OctopusOsUtils and move its test into the cli package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…o-cli-default-space

…est (#286) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…ments (#289)

…288)

…o-cli-default-space # Conflicts: # e2e/src/test/java/octopus/teamcity/e2e/test/OctopusConnectionBuildInformationE2ETest.java # e2e/src/test/java/octopus/teamcity/e2e/test/OctopusPromoteReleaseNewCliE2ETest.java # e2e/src/test/java/octopus/teamcity/e2e/test/OctopusPushPackageE2ETest.java # octopus-agent/src/main/java/octopus/teamcity/agent/cli/CLIBuildProcess.java # octopus-agent/src/test/java/octopus/teamcity/agent/cli/CLIBuildProcessTest.java # octopus-common/src/main/java/octopus/teamcity/common/SpaceSelection.java # octopus-server/src/main/java/octopus/teamcity/server/PropertiesValidator.java

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Additional command line arguments reach the Go CLI unchanged. Steps written for the legacy octo CLI can carry arguments the Go CLI rejects with only "unknown flag"; the build log now says where the argument came from. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

The Go CLI is bundled for amd64 and arm64 only. Every runner reported every agent as compatible, so a build could be sent to an agent whose JVM architecture has no bundled CLI and fail when the step started. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

…o-cli-default-space # Conflicts: # octopus-agent/src/main/java/octopus/teamcity/agent/cli/CLIBuildProcess.java

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

APErebus

LGTM!

# Conflicts: # octopus-agent/src/test/java/octopus/teamcity/agent/cli/CLIBuildProcessTest.java # octopus-server/src/main/java/octopus/teamcity/server/OctopusDeployReleaseRunType.java # octopus-server/src/main/java/octopus/teamcity/server/PropertiesValidator.java

APErebus and others added 9 commits October 20, 2026 12:21

Remove legacy CLI and default new Go CLI

2cb3273

Continue fixing

a03c553

Linting

0dfe4c4

Fix test

d6e1ee0

Merge branch 'main' into ap/default-to-new-cli

b1e1a61

The Go CLI archives are now downloaded at build time (#282). Drop the committed cli/ archives and point downloadOctopusCli at resources/cli/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge branch 'main' into ap/default-to-new-cli

dada9a1

Bring in the per-architecture Go CLI archives (#283). Port the architecture lookup into cli/OctopusOsUtils and move its test into the cli package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into ap/default-to-new-cli

efecfb4

Merge remote-tracking branch 'origin/main' into ap/default-to-new-cli

6acac59

fix: require an Octopus space instead of falling back to Default

3e9aa53

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions Bot added the fix label Oct 27, 2026

test: name the Octopus default space in the e2e tests

1792091

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

matt-richardson marked this pull request as draft October 27, 2026 03:02

matt-richardson and others added 8 commits October 27, 2026 17:17

Merge remote-tracking branch 'origin/main' into ap/default-to-new-cli

82f3ced

Merge remote-tracking branch 'origin/ap/default-to-new-cli' into mr/g…

75cba80

…o-cli-default-space

fix: refuse to save a Deploy release step whose release number is lat…

3d2949d

…est (#286) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

test: give the inline build information step a space

f83911d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs: update docs to remove old CLI references (#290)

6273b8b

fix: refuse to save a Create release step with --deployTo in its argu…

744f8b4

…ments (#289)

fix: use the bundled Go CLI whatever octopus_version a step carries (#…

929dfa9

…288)

test: drop the OCTOPUS_NEW_CLI switch from the e2e tests (#293)

aca1e4e

matt-richardson mentioned this pull request Oct 28, 2026

fix: explain an unknown flag from a step's additional arguments #295

Merged

matt-richardson and others added 5 commits October 30, 2026 10:06

docs: describe the retry and error classifier for a single CLI (#297)

f30e164

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/ap/default-to-new-cli' into mr/g…

d41580f

…o-cli-default-space # Conflicts: # octopus-agent/src/main/java/octopus/teamcity/agent/cli/CLIBuildProcess.java

matt-richardson mentioned this pull request Oct 30, 2026

chore: tidy legacy CLI references and javadocs #301

Merged

Base automatically changed from ap/default-to-new-cli to main November 5, 2026 04:10

Merge remote-tracking branch 'origin/main' into mr/go-cli-default-space

e6ce7e3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

matt-richardson marked this pull request as ready for review November 5, 2026 04:30

APErebus approved these changes Nov 9, 2026

View reviewed changes

matt-richardson enabled auto-merge (squash) November 9, 2026 03:14

matt-richardson self-assigned this Nov 9, 2026

matt-richardson merged commit b95c949 into main Nov 9, 2026
5 checks passed

matt-richardson deleted the mr/go-cli-default-space branch November 9, 2026 03:16

team-modern-deployments-bot mentioned this pull request Nov 9, 2026

chore(main): release 7.0.0 #302

Open

Navigation Menu

Repository navigation

fix: require an Octopus space instead of falling back to Default - #287

fix: require an Octopus space instead of falling back to Default#287
matt-richardson merged 25 commits into
mainfrom
mr/go-cli-default-space

matt-richardson commented Oct 27, 2026 •

edited

Loading

Uh oh!

APErebus left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

matt-richardson commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

APErebus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

matt-richardson commented Oct 27, 2026 •

edited

Loading