Repository navigation
fix: explain an unknown flag from a step's additional arguments - #295
Merged
matt-richardson merged 1 commit intoOct 29, 2026
Merged
Conversation
Additional command line arguments reach the Go CLI unchanged. Steps written for the legacy octo CLI can carry arguments the Go CLI rejects with only "unknown flag"; the build log now says where the argument came from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matt-richardson
marked this pull request as ready for review
October 29, 2026 23:37
APErebus
approved these changes
Oct 29, 2026
APErebus
added a commit
that referenced
this pull request
Nov 5, 2026
* Remove legacy CLI and default new Go CLI * Continue fixing * Linting * Fix test * fix: refuse to save a Deploy release step whose release number is latest (#286) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * docs: update docs to remove old CLI references (#290) * fix: refuse to save a Create release step with --deployTo in its arguments (#289) * fix: use the bundled Go CLI whatever octopus_version a step carries (#288) * test: drop the OCTOPUS_NEW_CLI switch from the e2e tests (#293) * docs: describe the retry and error classifier for a single CLI (#297) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix: explain an unknown flag from a step's additional arguments (#295) Additional command line arguments reach the Go CLI unchanged. Steps written for the legacy octo CLI can carry arguments the Go CLI rejects with only "unknown flag"; the build log now says where the argument came from. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix: mark agents without a bundled Go CLI as incompatible (#294) The Go CLI is bundled for amd64 and arm64 only. Every runner reported every agent as compatible, so a build could be sent to an agent whose JVM architecture has no bundled CLI and fail when the step started. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Matt Richardson <matt.richardson@octopus.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges into #276.
A step's additional command line arguments reach the Go CLI unchanged. Steps written for the legacy
octoCLI can carry arguments it doesn't have, such as--progress,--waitForDeploymentor--packageVersion. After upgrading, those steps fail with onlyError: unknown flag: --progress, which doesn't say that the argument came from the step's own settings. When a command fails with an unknown flag and the step has additional arguments, the build log now says so and points atoctopus <command> --help.Notes:
--deployToon a Create release step is already rejected by the step's validation. TeamCity also runs that validation when it matches a build to an agent (see fix: require an Octopus space instead of falling back to Default #287), so a saved step with--deployTostays queued with the reason in the agent's compatibility details rather than reaching the CLI./flagforms, whichoctoaccepted, are positional arguments to the Go CLI and fail with a different error. This hint doesn't cover them.🤖 Generated with Claude Code