Repository navigation
refactor: share the space field across the connection and step forms - #256
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
APErebus
approved these changes
Oct 11, 2026
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Split out of #239 to make it smaller. The connection form and all six step forms each had their own copy of the "Space name" field. Moving them into one include now means #239's space picker changes one file instead of seven, and its diff no longer carries the move.
Notes
noteparam.spacePicker.jspand its beanspaceKeysto match feat: pick an Octopus space from a dropdown and store its id #239, so that PR applies on top as edits to this file rather than adding it. For now it is still a plain text field.*UiTest*) pass locally, includingOctopusConnectionUiTest, which checks that a step's space row is hidden when its connection sets a space.🤖 Generated with Claude Code