Repository navigation
refactor: share the space summary across the step view pages - #257
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
APErebus
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Split out of #239 to make it smaller. The six step view pages each had their own copy of the "Space name" summary, and #239 adds a stored space id line to every one of them. With the summary in one include, that becomes one edit and drops most of the noise from #239's diff.
Notes
spaceKeysand declarespropertiesBean, matchingspacePicker.jspin refactor: share the space field across the connection and step forms #256, so feat: pick an Octopus space from a dropdown and store its id #239's added line applies here as-is../gradlew buildpasses. No e2e test opens a step's view page, so the rendered output has not been checked in a running TeamCity. View pages are loaded the same way as the edit forms, where the equivalent include in refactor: share the space field across the connection and step forms #256 passes the UI tests.🤖 Generated with Claude Code