Skip to content

fix: map the four new client const strings #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwan-joly merged 1 commit into from
Oct 12, 2026
Merged

fix: map the four new client const strings #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions src/NosCore.Packets/Enumerations/Game18NConstString.verified.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1889,7 +1889,7 @@ public enum Game18NConstString : short
// <summary>
AlreadyInYourParty = 455,
// <summary>
// Congratulations! You have a further member to your party: %s<NEW_TYPE><0>
// Congratulations! You have a new party member: %s<NEW_TYPE><0>
// <summary>
[Game18NArguments(typeof(string))]
SomeoneJoinGroup = 456,
Expand Down Expand Up @@ -7554,15 +7554,15 @@ public enum Game18NConstString : short
// <summary>
PhantomAppears = 1822,
// <summary>
// The 18th Anniversary Buff is now active!
// The Anniversary Buff is now active!
// <summary>
AnniversaryBuffActivated = 1823,
// <summary>
// The effect of the 18th Anniversary Medal is still active.
// The effect of the Anniversary Medal is still active.
// <summary>
AnniversaryMedalActivated = 1824,
// <summary>
// The effect of the 17th Anniversary Medal is now over.
// The effect of the Anniversary Medal is now over.
// <summary>
AnniversaryMedalOver = 1825,
// <summary>
Expand Down Expand Up @@ -11742,7 +11742,7 @@ public enum Game18NConstString : short
// <summary>
DestroyAllThePillarsByAttacking = 2851,
// <summary>
// Dodge the meteors! Try to avoid being hit as far as possible.
// Dodge the meteors! Try to avoid being hit as much as possible.
// <summary>
DodgeTheMeteorsTryToAvoid = 2852,
// <summary>
Expand Down Expand Up @@ -11797,5 +11797,24 @@ public enum Game18NConstString : short
// Defeat all mini-bosses.
// <summary>
DefeatAllMiniBosses = 2868,
// <summary>
// Family %s used a skill to increase fairy experience earned by its members.<NEW_TYPE><0>
// <summary>
[Game18NArguments(typeof(string))]
FamilyUsedSkillFairyExperience = 2869,
// <summary>
// Family %s used a skill to increase the chance of its members receiving an additional raid token.<NEW_TYPE><0>
// <summary>
[Game18NArguments(typeof(string))]
FamilyUsedSkillRaidToken = 2870,
// <summary>
// The medal has expired. Effect deactivated.
// <summary>
MedalExpired = 2871,
// <summary>
// %s has expired. Effect deactivated.<NEW_TYPE><0>
// <summary>
[Game18NArguments(typeof(string))]
HasExpiredEffectDeactivated = 2872,
}
}
52 changes: 26 additions & 26 deletions ...s/SerializerCorpusTests.ExpressionTreeSerializerOutputIsPinnedForEveryPacket.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,16 +398,16 @@ InboxPacket#1 => inbox #gbox^1^44^0
InboxPacket#7 => inbox #gbox^2^75^0
SayItemPacket#1 => sayitem 1 44 83 s15853 IconInfo 21 e_info 3^87^55^52^1^80^24^27^23^69^90^20^18^35^9^75^68^79^97^1^68^41^93^71 slinfo 3^99^83^94^74^40^54^48^31^23^57^67^95^60^4^11^59^5^52^57^s14805^4^39^98^17^44^42^74^92^97^6^26^77^25^53^90^1^88^41^59^3^23^38^75
SayItemPacket#7 => sayitem 9 75 77 s30408 IconInfo 43 e_info 8^37^53^78^1^53^59^96^45^47^58^74^95^71^58^9^5^81^27^96^55^30^7^6 slinfo 6^78^44^68^41^54^77^86^75^59^33^86^63^21^80^11^9^68^85^11^s22966^92^88^32^58^51^71^78^69^24^46^93^88^53^0^57^91^25^11^90^29^87^63^46
SayItemtPacket#1 => sayitemt 1 44 83 53 71 s7682 s13487 s30955
SayItemtPacket#7 => sayitemt 9 75 77 8 2862 s6782 s19137 s30753
SayItemtPacket#1 => sayitemt 1 44 83 53 51 s7682 s13487 s30955
SayItemtPacket#7 => sayitemt 9 75 77 8 2843 s6782 s19137 s30753
SayPacket#1 => say 1 44 8 s15853
SayPacket#7 => say 9 75 14 s30408
SayPetPacket#1 => say_p 21 s30144
SayPetPacket#7 => say_p 74 s275
Sayi2Packet#1 => sayi2 1 44 8 1703 21 0
Sayi2Packet#7 => sayi2 9 75 14 2108 43 0
SayiPacket#1 => sayi 1 44 8 1703 21 0 0 0 0
SayiPacket#7 => sayi 9 75 14 2108 43 0 0 0 0
Sayi2Packet#1 => sayi2 1 44 8 1683 21 0
Sayi2Packet#7 => sayi2 9 75 14 2068 43 0
SayiPacket#1 => sayi 1 44 8 1683 21 0 0 0 0
SayiPacket#7 => sayi 9 75 14 2068 43 0 0 0 0
SaytPacket#1 => sayt 1 44 8 s15853
SaytPacket#7 => sayt 9 75 14 s30408
SpeakPacket#1 => spk 1 44 15 s15853 s14221
Expand Down Expand Up @@ -644,8 +644,8 @@ StpmPacket#1 => stpm 21 44 83 53 21 82 87 55 52 90 80 24 27 23 69 90 20 18 35 9
StpmPacket#7 => stpm 74 75 77 8 43 82 37 53 78 12 53 59 96 45 47 58 74 95 71 58
TcInfoPacket#1 => tc_info 21 s30144 3 53 1 0 s13487 24 3 90 80 24 27 23 69 90 20 18 35 9 75 68 79 97 1 68 41 93 71 31 99 83 1 1 1 54 s21148
TcInfoPacket#7 => tc_info 74 s275 2 8 3 0 s19137 12 3 12 53 59 96 45 47 58 74 95 71 58 9 5 81 27 96 55 30 7 6 24 78 44 1 0 1 77 s30286
TitPacket#1 => tit 1371 s30144
TitPacket#7 => tit 1524 s275
TitPacket#1 => tit 1351 s30144
TitPacket#7 => tit 1504 s275
TitleInfoPacket#1 => titinfo 1 44 83 53
TitleInfoPacket#7 => titinfo 9 75 77 8
TitlePacket#1 => title 21.44 83.53
Expand Down Expand Up @@ -700,9 +700,9 @@ PidxSubPacket#1 => pidx_sub_packet 0 44
PidxSubPacket#7 => pidx_sub_packet 1 75
SMemoPacket#1 => s_memo 2 s30144
SMemoPacket#7 => s_memo 1 s275
SMemoi2Packet#1 => s_memoi2 2 1844 83 0 0 0
SMemoi2Packet#1 => s_memoi2 2 1804 83 0 0 0
SMemoi2Packet#7 => s_memoi2 1 275 77 0 0 0
SMemoiPacket#1 => s_memoi 2 1844 83
SMemoiPacket#1 => s_memoi 2 1804 83
SMemoiPacket#7 => s_memoi 1 275 77
ShopEndPacket#1 => shop_end 2
ShopEndPacket#7 => shop_end 2
Expand Down Expand Up @@ -734,10 +734,10 @@ DelayPacket#1 => delay 21 2 #gbox^3^53^0
DelayPacket#7 => delay 74 9 #gbox^1^8^0
DlgPacket#1 => dlg #gbox^1^44^0 #gbox^1^21^1 s13487
DlgPacket#7 => dlg #gbox^2^75^0 #gbox^0^43^1 s19137
Dlgi2Packet#1 => dlgi2 #gbox^1^44^0 #gbox^1^21^1 2167 55 0 0 0 0
Dlgi2Packet#7 => dlgi2 #gbox^2^75^0 #gbox^0^43^1 2157 53 0 0 0 0
DlgiPacket#1 => dlgi #gbox^1^44^0 #gbox^1^21^1 2167 55 0
DlgiPacket#7 => dlgi #gbox^2^75^0 #gbox^0^43^1 2157 53 0
Dlgi2Packet#1 => dlgi2 #gbox^1^44^0 #gbox^1^21^1 2151 55 0 0 0 0
Dlgi2Packet#7 => dlgi2 #gbox^2^75^0 #gbox^0^43^1 2133 53 0 0 0 0
DlgiPacket#1 => dlgi #gbox^1^44^0 #gbox^1^21^1 2151 55 0
DlgiPacket#7 => dlgi #gbox^2^75^0 #gbox^0^43^1 2133 53 0
FishOpenPacket#1 => fishopen
FishOpenPacket#7 => fishopen
NosCore.Packets.ServerPackets.UI.GuriPacket#1 => guri 6 44 83 53 21 82
Expand All @@ -746,30 +746,30 @@ IconPacket#1 => icon 1 44 83 53
IconPacket#7 => icon 9 75 77 8
InfoPacket#1 => info s15521
InfoPacket#7 => info s15674
Infoi2Packet#1 => infoi2 1371 44 0
Infoi2Packet#7 => infoi2 1524 75 0
InfoiPacket#1 => infoi 1371 0 0 44
InfoiPacket#7 => infoi 1524 0 0 75
Infoi2Packet#1 => infoi2 1351 44 0
Infoi2Packet#7 => infoi2 1504 75 0
InfoiPacket#1 => infoi 1351 0 0 44
InfoiPacket#7 => infoi 1504 0 0 75
NosCore.Packets.ServerPackets.UI.MallPacket#1 => mall 21
NosCore.Packets.ServerPackets.UI.MallPacket#7 => mall 74
ModalPacket#1 => modal 21 s30144
ModalPacket#7 => modal 74 s275
ModaliPacket#1 => modali 21 1844 83 0 0
ModaliPacket#1 => modali 21 1804 83 0 0
ModaliPacket#7 => modali 74 275 77 0 0
MsgPacket#1 => msg 5 s30144
MsgPacket#7 => msg 2 s275
Msgi2Packet#1 => msgi2 5 1844 83 0
Msgi2Packet#1 => msgi2 5 1804 83 0
Msgi2Packet#7 => msgi2 2 275 77 0
MsgiPacket#1 => msgi 5 1844 83 0 0 0 0
MsgiPacket#1 => msgi 5 1804 83 0 0 0 0
MsgiPacket#7 => msgi 2 275 77 0 0 0 0
PclearPacket#1 => p_clear
PclearPacket#7 => p_clear
QnaPacket#1 => qna #gbox^1^44^0 s15853
QnaPacket#7 => qna #gbox^2^75^0 s30408
Qnai2Packet#1 => qnai2 #gbox^1^44^0 1703 21 0 0 0 0
Qnai2Packet#7 => qnai2 #gbox^2^75^0 2108 43 0 0 0 0
QnaiPacket#1 => qnai #gbox^1^44^0 1703 21 0 0
QnaiPacket#7 => qnai #gbox^2^75^0 2108 43 0 0
Qnai2Packet#1 => qnai2 #gbox^1^44^0 1683 21 0 0 0 0
Qnai2Packet#7 => qnai2 #gbox^2^75^0 2068 43 0 0 0 0
QnaiPacket#1 => qnai #gbox^1^44^0 1683 21 0 0
QnaiPacket#7 => qnai #gbox^2^75^0 2068 43 0 0
RdiPacket#1 => rdi 21 44
RdiPacket#7 => rdi 74 75
NosCore.Packets.ServerPackets.UI.ShopClosePacket#1 => shopclose 21
Expand All @@ -789,7 +789,7 @@ ZzimPacket#7 => zzim
ClPacket#1 => cl 21 1 0
ClPacket#7 => cl 74 0 0
InPacket#1 => in 1 s30144 s12383 53 21 82 87 3 0 0 68 4 27.23.69.90.20.18.35.9.75.68 79 97 0 68 41 93 0 31 0 83 9474 4054 48.31 s17923 57 0 95 2 4 11 59 0|1 0 5 4 39 98 17 1 42 74 92 97 6 26 77 25 2 1 1 s15588 41 59 3 23 38 75 57 87 65 0 81 71 12
InPacket#7 => in 9 s275 s19477 8 43 82 37 1 0 2 49 4 96.45.47.58.74.95.71.58.9.5 81 27 1 55 30 7 1 24 1 44 6841 5477 86.75 s10759 33 1 63 2 80 11 9 1|0 0 66 92 88 32 58 0 71 78 69 24 46 93 88 53 1 0 91 s6425 11 90 29 87 63 46 29 70 51 1 193 90 8
InPacket#7 => in 9 s275 s19477 8 43 82 37 1 0 2 49 4 96.45.47.58.74.95.71.58.9.5 81 27 1 55 30 7 1 24 1 44 6841 5477 86.75 s10759 33 1 63 2 80 11 9 1|0 0 66 92 88 32 58 0 71 78 69 24 46 93 88 53 1 0 91 s6425 11 90 29 87 63 46 29 70 51 1 181 90 8
FStashAllPacket#1 => f_stash_all 21 44.83.53.21.82.87.55 52.90.80.24.27.23.69
FStashAllPacket#7 => f_stash_all 74 75.77.8.43.82.37.53 78.12.53.59.96.45.47
FStashClientPacket#1 => f_stash 21.44.83.53.21.82.87 55.52.90.80.24.27.23
Expand Down
Loading