Repository navigation
fix: map the four new client const strings - #539
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe update changes selected game string text, adds four ChangesGame string entries
Serializer corpus expectations
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The enum additions account for the updated packet snapshots, and no concrete behavior regression is evident. No actionable merge blocker remains. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main change: mapping four new client const strings. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
-
📝 Generate docstrings
-
-
-
- Commit to this branch
- Create a new PR
-
-
🧪 Generate unit tests (beta)
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
The live client added const strings 2869-2872 (family fairy experience and raid token skills, medal expiry), which failed I18NDocumentation on every build. Five existing strings were also reworded, which only changes the generated comments. The serializer corpus snapshot moves because it picks seeded values from Game18NConstString, which now has four more members. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1113fc5 to
09c04f4
Compare
1 participant
masteris red onI18NDocumentation. The test downloads the live client'sconststring_UK.dat, and the game added four strings:FamilyUsedSkillFairyExperienceFamilyUsedSkillRaidTokenMedalExpiredHasExpiredEffectDeactivatedThe names follow the older descriptive style (
FamilyUsedSkillGold,MedalEreniaExpired) rather than the auto-numberedFamilyUsedASkillToIncrease5.Also in the diff:
SerializerCorpusTestssnapshot: the corpus picks seededGame18NConstStringvalues, so the four new members shift the picks in the 16 packets that carry the enum (sayi,msgi,inviaInNonPlayerSubPacket.Title, …). No serializer behavior changes.All 128 tests pass locally.
🤖 Generated with Claude Code
Summary by CodeRabbit