Skip to content

Drop web-ext's adbkit, and node-forge with it (fixes #301) #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nawid3333 merged 1 commit into from
Oct 11, 2026
Merged

Drop web-ext's adbkit, and node-forge with it (fixes #301) #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 1 addition & 68 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,15 @@ overrides:
# 1.6.0 (its newest) pins exactly 1.10.0. fx-runner calls only parse(), on a binary-args
# string that nothing here passes; 1.11/1.12 only add parse support for rarer syntax.
shell-quote: ^1.11.0
# Dependabot #60, issue #301 (high, GHSA-86w9-cpqp-85rv): node-forge <= 1.4.0 accepts a
# forged RSA PKCS#1 v1.5 signature, and no release fixes it (2026-10-11: four outside fix
# PRs, no word from its maintainer since June). It comes only through web-ext ->
# @devicefarmer/adbkit, which web-ext loads only to run an extension on Firefox for Android
# (extension-runners/index.js imports firefox-android.js, util/adb.js's only importer,
# when that is the target). build, lint, sign, the desktop run and util/submit-addon never
# reach it. Removing adbkit removes node-forge; `web-ext run -t firefox-android`, which
# nothing here does, is what goes with it.
'web-ext>@devicefarmer/adbkit': '-'
allowBuilds:
geckodriver: true
esbuild: true
Expand Down
Loading