Repository navigation
Drop web-ext's adbkit, and node-forge with it (fixes #301) - #438
Merged
Merged
Conversation
…#60, issue #301) node-forge <= 1.4.0 accepts a forged RSA PKCS#1 v1.5 signature (GHSA-86w9-cpqp-85rv, high) and no release fixes it: four outside fix PRs, no word from its maintainer since June (2026-10-11). It came only through web-ext -> @devicefarmer/adbkit, which web-ext loads only to run an extension on Firefox for Android. An override removes adbkit, and with it node-forge, bluebird, split, through and a second debug. Checked: web-ext's build, lint, sign and run commands, the desktop runner and util/submit-addon (tools/fetch-amo-signed.mjs) all load; only the Android runner does not. build, build:keep, lint:github, lint:amo (0 errors), lint, typecheck, vitest 2260. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301 (Dependabot alert #60, GHSA-86w9-cpqp-85rv, high).
Is a fix on the way? No.
The fix: we don't need the package at all
web-ext→@devicefarmer/adbkit. web-ext loads adbkit only to run an extension on Firefox for Android:extension-runners/index.jsimportsfirefox-android.js, the only importer ofutil/adb.js, only for that target.pnpm-workspace.yaml('web-ext>@devicefarmer/adbkit': '-') removes adbkit, node-forge and four packages only they used. The lockfile loses them, nothing else.web-ext run -t firefox-android, which nothing here does.Checked
web-ext/util/submit-addon(used bytools/fetch-amo-signed.mjs).build,build:keep,lint:github,lint:amo(0 errors), lint, typecheck, vitest 2260.security-alerts.ymlthen closes Security alert: node-forge #301.🤖 Generated with Claude Code