Skip to content

XIOS2 coupled model - #464

Merged
Lottie Turner (mo-lottieturner) merged 5 commits into
MetOffice:mainfrom
iboutle:cpl_xios2
Oct 2, 2026
Merged

Lottie Turner (mo-lottieturner) merged 5 commits into
MetOffice:mainfrom
iboutle:cpl_xios2

Conversation

@iboutle

@iboutle iboutle commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

PR Summary

Sci/Tech Reviewer: Dan Copsey (@DanCopsey)
Code Reviewer: Lottie Turner (@mo-lottieturner)

Changes needed to use xios2 in coupled model

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - cpl_xio2/run1

Suite Information

Item Value
Suite Name cpl_xio2/run1
Suite User ian.boutle
Workflow Start 2026-09-11T15:41:47
Groups Run developer
Dependency Reference Main Like
lfric_core iboutle/lfric_core@cpl_xios2 False
SimSys_Scripts MetOffice/SimSys_Scripts@cab3315 True

Task Information

✅ succeeded tasks - 433

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the HPC Optimisation Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Sep 11, 2026
@iboutle iboutle mentioned this pull request Sep 11, 2026
18 of 28 tasks
@iboutle iboutle added the Linked Apps This PR is linked to a MetOffice/lfric_apps PR label Sep 11, 2026
@iboutle iboutle added this to the Autumn 2026 milestone Sep 11, 2026
@iboutle
iboutle marked this pull request as ready for review September 15, 2026 09:08
@DanCopsey

Copy link
Copy Markdown

I approve and move this into code review.

@DanCopsey Dan Copsey (DanCopsey) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@github-actions github-actions Bot removed the cla-modified The CLA has been modified as part of this PR - added by GA label Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and tests fine. Approved pending apps testing for #lfric_apps:774

@mo-lottieturner
Lottie Turner (mo-lottieturner) merged commit 17d81d9 into MetOffice:main Oct 2, 2026
6 checks passed
Ed Hone (EdHone) pushed a commit to EdHone/lfric_core that referenced this pull request Oct 2, 2026
Co-authored-by: Lottie Turner <120099755+mo-lottieturner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Linked Apps This PR is linked to a MetOffice/lfric_apps PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants