Repository navigation
Coupled checkpoint restart - #774
Conversation
|
Hi Ian, |
Sorry Dan, I should have explained what's going on better - it does do all of that. The new |
|
Thanks for clearing that up Ian. Now that I have looked at the coupled rose-stem setup I see it all now. I approve and move this into code review. |
Dan Copsey (DanCopsey)
left a comment
There was a problem hiding this comment.
I approve.
|
I've added a new commit preventing the crun coupled tasks from running before the build has finished |
James Bruten (james-bruten-mo)
left a comment
There was a problem hiding this comment.
I'm happy with the rose-stem changes here
Lottie Turner (mo-lottieturner)
left a comment
There was a problem hiding this comment.
Hi Ian. A couple of comments:
- please make note when files are added as these will need to be added to
$BIG_DATA_DIR - A note on where these files are living currently is also appreciated, along with some sort of provenance.
- These new files will need to be approved by someone who knows what they're looking at (ie not me) - we can discuss who when you're back from leave
| @@ -1,5 +1,7 @@ | |||
| [namelist:files] | |||
| ancil_directory='$BIG_DATA_DIR/ancils/basic-gc/Ticket3810/C48' | |||
| sea_ice_ancil_path='sstice/hadisst_6190/qrclim.sstice_ice' | |||
There was a problem hiding this comment.
Where are these files living? In future please flag on the PR summary that there are files that need to be added to $BIG_DATA_DIR
There was a problem hiding this comment.
There are no new files - this is just a namelist update to enable the new coupled climate task to run, the files already exist in big_data_dir
|
Just adding a note that this needs to be on main before #805 |
|
And #782 |
|
And also blocks #740 |
dc6938f
into
MetOffice:main
PR Summary
Sci/Tech Reviewer: Dan Copsey (@DanCopsey)
Code Reviewer: Lottie Turner (@mo-lottieturner)
linked XIOS2 coupled model lfric_core#464
blocks Migrate to XIOS 3 #805
blocks Convert checkpoint files from legacy domains to layered CF #782
blocks Enable variable precision checkpoint-restart files #740
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - cpl_ckp/run1
Suite Information
Task Information
✅ succeeded tasks - 1225
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review