Skip to content

fix: add specs for mapper and github strategy, auto-compute reputation, and add milestone close - #708

Merged
chonilius merged 1 commit into
MergeFi:mainfrom
emdevelopa:fix/emdevelopa-users-github-reputation-milestone
Oct 20, 2026
Merged

chonilius merged 1 commit into
MergeFi:mainfrom
emdevelopa:fix/emdevelopa-users-github-reputation-milestone

Conversation

@emdevelopa

@emdevelopa emdevelopa commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

This PR resolves the 4 issues assigned to @emdevelopa:

  1. User Mapper Spec: Added comprehensive tests in src/users/users.mapper.spec.ts validating mapping to PublicUserDto.
  2. GitHub Strategy Spec: Added unit tests in src/auth/strategies/github.strategy.spec.ts validating OAuth profile extraction and upsert.
  3. Reputation Snapshot Creation: Wired reputation.recompute event emission and lazy snapshot computation in ReputationService.getLatest.
  4. Milestone Close & Escrow Refund: Implemented POST /milestones/:id/close to refund remaining unspent budget and transition to CLOSED.

Closes #598
Closes #594
Closes #589
Closes #587

…on, and add milestone close

- Add unit test for users.mapper.ts (Closes MergeFi#598)
- Add unit test for github.strategy.ts (Closes MergeFi#594)
- Auto-compute reputation snapshot on demand and event (Closes MergeFi#589)
- Add close milestone endpoint with escrow refund (Closes MergeFi#587)

Closes MergeFi#598, MergeFi#594, MergeFi#589, MergeFi#587
@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@emdevelopa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

@emdevelopa is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

@chonilius
chonilius merged commit 8ed1723 into MergeFi:main Oct 20, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants