Skip to content

users/users.mapper.ts has no spec file #598

Closed

Description

@chonilius

Problem

src/users/users.mapper.ts toPublicUser is the only thing preventing email and nested githubAccount tokens from leaking (#359). There is no *.spec.ts beside it, and no other spec imports it.

Suggested fix

Add a unit spec covering: asserting that email, githubAccount and tokens are absent and every public field is present.

Related: #359

Activity

  1. added
    testingTesting/QA infrastructure
    Stellar WaveIssues in the Stellar wave program
    and removed
    Stellar WaveIssues in the Stellar wave program
    on Oct 13, 2026
  2. khanavi272-spec commented on Oct 19, 2026

    @khanavi272-spec

    @khanavi272-spec has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’d like to take this issue and work on implementing a solution. I’m interested in contributing to the project and would appreciate it if you could assign this issue to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @khanavi272-spec to this issue.

  3. uscopumpi commented on Oct 19, 2026

    @uscopumpi

    @uscopumpi has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Please assign this issues for me please I will work on it perfect

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @uscopumpi to this issue.

  4. johnagana-dev commented on Oct 19, 2026

    @johnagana-dev

    @johnagana-dev has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi, maintainer. May i be assigned to this issue?

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @johnagana-dev to this issue.

  5. emdevelopa commented on Oct 19, 2026

    @emdevelopa
    Contributor

    @emdevelopa has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer! I’d like to work on this issue. I’ve reviewed the requirements and would be happy to take it up. Please assign it to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @emdevelopa to this issue.

  6. yodakkak commented on Oct 19, 2026

    @yodakkak

    @yodakkak has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer! I'd love to add the unit test spec for users.mapper.ts (toPublicUser). Ready to submit a clean PR with passing tests right away — please assign me!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @yodakkak to this issue.

  7. drips-wave commented on Oct 19, 2026

    @drips-wave

    Congratulations, @emdevelopa! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @emdevelopa: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  8. grantfox-oss commented on Oct 20, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @emdevelopa's PR #708 was approved and merged by @chonilius.

    🏆 @emdevelopa: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (599 total points). Track your full progress on GrantFox.

    👏 Great work, @emdevelopa! Keep contributing to MergeFi.

  9. drips-wave commented on Oct 20, 2026

    @drips-wave

    This issue has been completed by @emdevelopa as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @emdevelopa: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  10. added a commit that references this issue on Oct 20, 2026
    a4f6429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programgood first issueGood for newcomerstestingTesting/QA infrastructure

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions