Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33035e20e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if kind in ("ip-src", "ip-dst"): | ||
| for service in resource.get("services", [])[:limit]: | ||
| obj = _object(event, attribute, "network-connection") | ||
| obj.add_attribute("ip-dst", value=value, to_ids=False) |
There was a problem hiding this comment.
When the input attribute is ip-src, every generated network-connection hard-codes the address as ip-dst, changing the indicator's directional meaning and causing the enriched object to correlate it as a destination. Use the input attribute type for the object relation so ip-src lookups remain sources.
Useful? React with 👍 / 👎.
Analysts can query the Censys host enrichment endpoint with a platform token and organization ID, retrieve web properties on ports 80 and 443, or retrieve certificate metadata. Host services become referenced network objects; annotations retain provider details and available scores. Configuration and API usage are documented.
Includes a usage guide and focused adapter tests.
Validation:
19 passed, 1 warning in 0.73swithpytest -q tests/test_censys_enrichmentapis.py; flake8 passed for the module. The combined enrichment regression check passed 389 tests.Authenticated provider API validation remains pending. Tests use sanitized fixtures; no provider credentials are included.
Review updates: Preserve source IP direction and the corresponding source/destination service port.
Updated validation: 20 passed, 1 warning in 0.65s; module lint passed. Combined regression validation passed 409 tests.