Repository navigation
configure: fall back to the default scheme for SITEPY - #4726
Merged
Merged
Conversation
The 2.9 merge 2511cf1 took the 2.9 SITEPY line, which falls back to a hardcoded /usr/lib/python3/dist-packages when neither the deb_system nor the rpm_prefix scheme exists. On Gentoo that path is not on sys.path, so the linuxcnc module is not found. Master used to fall back to the interpreter's default scheme; restore that. Reported by Alec Ari (NTULINUX). Fixes LinuxCNC#4717
Contributor
|
Can confirm, it's working again, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4717.
When I merged 2.9 into master (2511cf1), I took the 2.9 SITEPY line. Its fallback is a hardcoded
/usr/lib/python3/dist-packages, used when neither thedeb_systemnor therpm_prefixscheme exists. Gentoo has neither, and that path is not on itssys.path, soimport linuxcncfails withoutPYTHONPATH.Before the merge, master fell back to the interpreter's default scheme. This restores that: the fallback is now
sysconfig.get_path('platlib'), which on Gentoo gives/usr/lib/python3.X/site-packages. Debian and Fedora pickdeb_system/rpm_prefixfirst, so nothing changes there.2.9 is unchanged.
@NTULINUX could you test this on Gentoo?