Skip to content

feat(pr-validation)!: smoke test the breaking change approval gate #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bedatty wants to merge 13 commits into from
Closed

feat(pr-validation)!: smoke test the breaking change approval gate #906

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f8d5506
feat(pr-validation)!: smoke test the breaking change approval gate
bedatty Oct 15, 2026
229bdd0
Merge branch 'develop' into test/breaking-change-gate-smoke
bedatty Oct 15, 2026
4a33204
Merge branch 'develop' into test/breaking-change-gate-smoke
bedatty Oct 15, 2026
607848b
test(pr-validation): probe whether a push cancels the pending approval
bedatty Oct 15, 2026
de70a29
Merge branch 'develop' into test/breaking-change-gate-smoke
bedatty Oct 16, 2026
ab25957
Merge branch 'develop' into test/breaking-change-gate-smoke
bedatty Oct 16, 2026
be6218e
Merge branch 'develop' into test/breaking-change-gate-smoke
bedatty Oct 16, 2026
55195ec
Merge branch 'develop' into test/breaking-change-gate-smoke
bedatty Oct 16, 2026
d578fe0
feat(pr-validation): one comment for the breaking change, not two
bedatty Oct 16, 2026
691eb27
refactor(pr-validation): detect through the API, check out nothing
bedatty Oct 16, 2026
8c60373
Merge branch 'develop' into test/breaking-change-gate-smoke
bedatty Oct 16, 2026
5b8d64b
Merge branch 'develop' into test/breaking-change-gate-smoke
bedatty Oct 16, 2026
ff8d64c
test(pr-validation): probe the two-label lifecycle on a live PR
bedatty Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/breaking-change-approval.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,3 +536,9 @@ python3 src/validate/breaking-change-guard/test-workflow.py
orchestrated composite exists with its README and is pinned, that the preflight
runs before the gate, that `outcome` does not declare a permission it cannot
escalate to, and that a pull request is closed only on a recorded rejection.

<!-- smoke test: exercises the breaking-change approval gate. This PR is not meant to be merged. -->

<!-- concurrency probe: does a push cancel the previous pending approval? -->

<!-- label lifecycle probe -->
Loading